aws-load-balancer-controller icon indicating copy to clipboard operation
aws-load-balancer-controller copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Provide more defaults via IngressClassParams

Open visit1985 opened this issue 3 years ago • 25 comments

Is your feature request related to a problem? Even after introducing IngressClass/IngressClassParams we have a lot of redundant annotations in our Ingress definitions for the same Ingress group:

  • alb.ingress.kubernetes.io/actions.ssl-redirect
  • alb.ingress.kubernetes.io/certificate-arn
  • alb.ingress.kubernetes.io/listen-ports
  • ~~alb.ingress.kubernetes.io/ssl-policy~~

Describe the solution you'd like We would like to specify the defaults for these annotations as IngressClassParams.

visit1985 avatar Apr 05 '22 14:04 visit1985

/kind feature

visit1985 avatar Apr 05 '22 14:04 visit1985

I'd add to this:

  • alb.ingress.kubernetes.io/wafv2-acl-arn

Additionally, updating IngressClassParams appears to only affect new ALBs, not existing ALBs. While I can understand the reasoning behind this, having changes to the IngressClassParams optionally trigger updates to all ALBs managed by the controller would be helpful. Especially for users of ALBs using group.name tagging, trying to update ALB shared attributes via application ingress annotations is fraught and unpredictable.

zmully avatar Apr 08 '22 16:04 zmully

We will put it in the roadmap, this requires further design to incorporate the attributes in the ingress class params.

kishorj avatar Apr 20 '22 22:04 kishorj

Similar issue: https://github.com/kubernetes-sigs/aws-load-balancer-controller/issues/2311

nikskiz avatar May 25 '22 09:05 nikskiz

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 23 '22 09:08 k8s-triage-robot

/remove-lifecycle stale

visit1985 avatar Aug 23 '22 14:08 visit1985

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 21 '22 15:11 k8s-triage-robot

/remove-lifecycle stale

visit1985 avatar Nov 21 '22 16:11 visit1985

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 19 '23 16:02 k8s-triage-robot

/remove-lifecycle stale

visit1985 avatar Feb 19 '23 19:02 visit1985

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 20 '23 19:05 k8s-triage-robot

/remove-lifecycle stale

visit1985 avatar May 22 '23 06:05 visit1985

ssl-policy can be set now: https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.5/guide/ingress/ingress_class/#specsslpolicy

visit1985 avatar May 22 '23 06:05 visit1985

is there an update on this issue? specifically for waf purposes

omri-shilton avatar Jan 17 '24 14:01 omri-shilton

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Apr 16 '24 14:04 k8s-triage-robot

/remove-lifecycle stale

Constantin07 avatar Apr 16 '24 15:04 Constantin07

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 15 '24 16:07 k8s-triage-robot

/remove-lifecycle stale

zmully avatar Jul 18 '24 14:07 zmully