aws-iam-authenticator
aws-iam-authenticator copied to clipboard
kubernetes-sigs
Partial upgrade of AWS SDK Go packages from V1 to V2
What this PR does / why we need it: Upgrades some packages of the AWS SDK Go from V1 to V2. The AWS SDK Go V1 is being deprecated on July 31, 2025: https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/.
This PR upgrades all packages except the github.com/aws/aws-sdk-go/aws/endpoints package, which is used in partition verification. Given that upgrading that particular functionality will require larger changes, its changes will be pushed out in a separate PR.
Testing:
Ran unit and e2e tests via make test and make e2e. Manually checked that token caching worked by checking that the value of X-Amz-Security-Token remained unchanged when using cached tokens within the 15 minute expiry window. Some output has been truncated.
(25-06-05 22:07:08) <0> [/aws-iam-authenticator]
panatula % AWS_PROFILE=dev /aws-iam-authenticator/_output/bin/aws-iam-authenticator token --cache -i panatulacontrol --token-only
k8s-aws-v1.aHR0...QxZQ
(25-06-05 22:07:14) <0> [/aws-iam-authenticator]
panatula % echo "aHR0...zQxZQ"
| base64 -d
https://sts.us-west-2.amazonaws.com/?Action=GetCallerIdentity&Version=2011-06-15&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=XXXXXXXXXXXXXXXX%2F20250605%2Fus-west-2%2Fsts%2Faws4_request&X-Amz-Date=20250605T220714Z&X-Amz-Expires=60&X-Amz-Security-Token=IQoJb3JpZ2lu...FxIB7vxw7hxSINB5PTuY%3D&X-Amz-SignedHeaders=host%3Bx-k8s-aws-id&X-Amz-Signature=98d0...741ebase64: invalid input
(25-06-05 22:07:25) <1> [/aws-iam-authenticator]
panatula % AWS_PROFILE=dev /aws-iam-authenticator/_output/bin/aws-iam-authenticator token --cache -i panatulacontrol --token-only
k8s-aws-v1.aHR0...YwZg
(25-06-05 22:07:28) <0> [/aws-iam-authenticator]
panatula % echo "aHR0...YwZg"
| base64 -d
https://sts.us-west-2.amazonaws.com/?Action=GetCallerIdentity&Version=2011-06-15&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=XXXXXXXXXXXXXXXX%2F20250605%2Fus-west-2%2Fsts%2Faws4_request&X-Amz-Date=20250605T220728Z&X-Amz-Expires=60&X-Amz-Security-Token=IQoJb3JpZ2lu...FxIB7vxw7hxSINB5PTuY%3D&X-Amz-SignedHeaders=host%3Bx-k8s-aws-id&X-Amz-Signature=8ffe...4f0fbase64: invalid input
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Addresses #736, but does not fully close it.
Welcome @gargipanatula!
It looks like this is your first PR to kubernetes-sigs/aws-iam-authenticator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/aws-iam-authenticator has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @gargipanatula. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gargipanatula, kmala
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [kmala]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment