aws-iam-authenticator
aws-iam-authenticator copied to clipboard
kubernetes-sigs
chore: Update e2e and integration test Kubernetes/kOps versions
What this PR does / why we need it:
- Update e2e and integration test Kubernetes/kOps versions - these look like they haven't been updated for a few years so bumping to the latest (latest K8s version supported in EKS)
- Replace makefile with script to update codegen
- The makefile driven code generation was removed in upstream in 1.25 and replaced with a script https://github.com/kubernetes/kubernetes/pull/112819
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
will need to spend a bit more time to look into this, converting to draft for now
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bryantbiggs Once this PR has been reviewed and has the lgtm label, please assign wongma7 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
somewhere, we are using an older version of the authenticator in the e2e test but I can't spot where in the code. From the e2e test output:
W0429 11:46:49.577654 6344 builder.go:232] failed to digest image "602401143452.dkr.ecr.us-west-2.amazonaws.com/amazon/aws-iam-authenticator:v0.5.12": GET https://602401143452.dkr.ecr.us-west-2.amazonaws.com/v2/amazon/aws-iam-authenticator/manifests/v0.5.12: unexpected status code 401 Unauthorized: Not Authorized
@bryantbiggs: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-aws-iam-authenticator-e2e | 759d2f23502f5627622e9ffcf941221215ddef8f | link | true | /test pull-aws-iam-authenticator-e2e |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
commit https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/716/commits/a08d60d4844beb54adf5e3e20bc338349178772d corrects changes made in https://github.com/kubernetes-sigs/aws-iam-authenticator/commit/cc68d2315305ba17452a5a4f1868db14b77a0090
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.