aws-iam-authenticator icon indicating copy to clipboard operation
aws-iam-authenticator copied to clipboard

add support for e2e latency for dynamic mode

Open minj131 opened this issue 1 year ago • 8 comments

What this PR does / why we need it:

This adds logic to support e2e latency for dynamic mode and dynamic backend mode files.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

minj131 avatar Jan 30 '24 21:01 minj131

Welcome @minj131!

It looks like this is your first PR to kubernetes-sigs/aws-iam-authenticator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-iam-authenticator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jan 30 '24 21:01 k8s-ci-robot

Hi @minj131. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 30 '24 21:01 k8s-ci-robot

/ok-to-test

nnmin-aws avatar Jan 30 '24 21:01 nnmin-aws

/re-test

nnmin-aws avatar Feb 19 '24 18:02 nnmin-aws

/retest

nnmin-aws avatar Feb 19 '24 18:02 nnmin-aws

/lgtm

nnmin-aws avatar Feb 19 '24 18:02 nnmin-aws

/ok-to-test

jyotimahapatra avatar Feb 19 '24 19:02 jyotimahapatra

/lgtm

nnmin-aws avatar Feb 26 '24 19:02 nnmin-aws

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jyotimahapatra, minj131

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 28 '24 20:02 k8s-ci-robot

/lgtm

nnmin-aws avatar Feb 28 '24 20:02 nnmin-aws