aws-iam-authenticator icon indicating copy to clipboard operation
aws-iam-authenticator copied to clipboard

chore: Update CLI dependencies `cobra` and `viper`

Open bryantbiggs opened this issue 1 year ago • 6 comments

What this PR does / why we need it:

  • Update CLI dependencies cobra and viper to latest; reduces the number of transitive dependencies and patches vulnerabilities

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

bryantbiggs avatar Jan 27 '24 00:01 bryantbiggs

Hi @bryantbiggs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 27 '24 00:01 k8s-ci-robot

/ok-to-test

nnmin-aws avatar Jan 27 '24 00:01 nnmin-aws

/lgtm

nnmin-aws avatar Jan 27 '24 00:01 nnmin-aws

/retest

bryantbiggs avatar Jan 27 '24 13:01 bryantbiggs

/lgtm

nnmin-aws avatar Jan 29 '24 17:01 nnmin-aws

/retest

bryantbiggs avatar Mar 20 '24 19:03 bryantbiggs

/retest-required

bryantbiggs avatar Mar 20 '24 20:03 bryantbiggs

/lgtm /approve

will need rebase on https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/687 and https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/706

wongma7 avatar Apr 22 '24 19:04 wongma7

/retest

bryantbiggs avatar Apr 22 '24 20:04 bryantbiggs

cc @wongma7

bryantbiggs avatar Apr 22 '24 22:04 bryantbiggs

/lgtm /approve

wongma7 avatar Apr 25 '24 21:04 wongma7

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryantbiggs, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 25 '24 21:04 k8s-ci-robot

An error occurred (NoSuchEntity) when calling the DeleteRole operation: The role with name aws-iam-authenticator-test-role-KubernetesAdmin cannot be found.

seems the role name gets reused and tests race each other.

wongma7 avatar Apr 25 '24 22:04 wongma7

/retest

bryantbiggs avatar Apr 26 '24 00:04 bryantbiggs

/lgtm

wongma7 avatar Apr 26 '24 18:04 wongma7