aws-iam-authenticator
aws-iam-authenticator copied to clipboard
chore: Update app K8s dependencies
What this PR does / why we need it:
- Updates application's K8s dependencies
- Closes #627
- Resolves #635
- Relates #611
This is part of splitting out changes from #684 in smaller increments. make test passes successfully locally on this change set
...
--- PASS: TestGetIdentityFromSTSResponse (0.00s)
--- PASS: TestGetIdentityFromSTSResponse/Root_User (0.00s)
--- PASS: TestGetIdentityFromSTSResponse/User (0.00s)
--- PASS: TestGetIdentityFromSTSResponse/Role (0.00s)
--- PASS: TestGetIdentityFromSTSResponse/Federated_User (0.00s)
PASS
coverage: 75.7% of statements
ok sigs.k8s.io/aws-iam-authenticator/pkg/token 1.442s coverage: 75.7% of statements
go tool cover -html=coverage.out -o coverage.html
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Hi @bryantbiggs. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test
/lgtm
/retest
/retest
struggling to figure out this ginkgo error:
Unknown Decorator
var _ = Describe("[apiserver] the apiserver", framework.WithDisruptive(), func() {
/home/prow/go/src/github.com/kubernetes-sigs/aws-iam-authenticator/tests/e2e/apiserver_test.go:44
[Container] node was passed an unknown decorator:
'framework.label{parts:[]string{"Disruptive"}, extra:""}'
Learn more at: http://onsi.github.io/ginkgo/#node-decorators-overview
Which was previously:
ERROR: E2E suite initialization was faulty, these errors must be fixed:
ERROR: apiserver_test.go:44: [Disruptive] in plain text is deprecated and must be added through WithDisruptive instead
cc @jyotimahapatra if you get a moment to re-review, thank you!
@jyotimahapatra / @nnmin-aws let me know if there are any other comments or feedback that I can help address, thank you!
/lgtm
/lgtm
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bryantbiggs, wongma7
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [wongma7]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment