aws-iam-authenticator icon indicating copy to clipboard operation
aws-iam-authenticator copied to clipboard

Upgrade to k8s API v0.24.0

Open ahmedwaleedmalik opened this issue 3 years ago • 9 comments

Signed-off-by: Waleed Malik [email protected]

ahmedwaleedmalik avatar May 31 '22 12:05 ahmedwaleedmalik

Welcome @ahmedwaleedmalik!

It looks like this is your first PR to kubernetes-sigs/aws-iam-authenticator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-iam-authenticator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar May 31 '22 12:05 k8s-ci-robot

Hi @ahmedwaleedmalik. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 31 '22 12:05 k8s-ci-robot

/assign @nckturner

ahmedwaleedmalik avatar May 31 '22 12:05 ahmedwaleedmalik

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 31 '22 22:05 k8s-ci-robot

/ok-to-test

nckturner avatar Jun 01 '22 20:06 nckturner

So the tests are failing but I can't even run them locally?

ahmedwaleedmalik avatar Jun 02 '22 10:06 ahmedwaleedmalik

any updates on this? Thanks.

tamalsaha avatar Jun 09 '22 11:06 tamalsaha

@ahmedwaleedmalik: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 02 '22 11:07 k8s-ci-robot

@ahmedwaleedmalik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-iam-authenticator-unit ecb35c1650dd681d46fe9c474ebb89776a4b08e4 link true /test pull-aws-iam-authenticator-unit
pull-aws-iam-authenticator-integration ecb35c1650dd681d46fe9c474ebb89776a4b08e4 link true /test pull-aws-iam-authenticator-integration
pull-aws-iam-authenticator-e2e ecb35c1650dd681d46fe9c474ebb89776a4b08e4 link true /test pull-aws-iam-authenticator-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Aug 11 '22 00:08 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 09 '22 00:11 k8s-triage-robot

@ahmedwaleedmalik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-iam-authenticator-unit ecb35c1650dd681d46fe9c474ebb89776a4b08e4 link true /test pull-aws-iam-authenticator-unit
pull-aws-iam-authenticator-integration ecb35c1650dd681d46fe9c474ebb89776a4b08e4 link true /test pull-aws-iam-authenticator-integration
pull-aws-iam-authenticator-e2e ecb35c1650dd681d46fe9c474ebb89776a4b08e4 link true /test pull-aws-iam-authenticator-e2e
pull-aws-iam-authenticator-e2e-kind ecb35c1650dd681d46fe9c474ebb89776a4b08e4 link true /test pull-aws-iam-authenticator-e2e-kind

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Nov 16 '22 22:11 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Dec 16 '22 23:12 k8s-triage-robot