aws-iam-authenticator icon indicating copy to clipboard operation
aws-iam-authenticator copied to clipboard

v5.7.0 release doesn't contain authenticators in assets

Open fm100 opened this issue 3 years ago • 15 comments

All the other releases contain aws-iam-authenticator-{VERSION}-{PLATFORM}-amd64 files but v5.7.0 does not. Is it intended change for the release?

fm100 avatar Apr 08 '22 20:04 fm100

FYI, this is breaking https://circleci.com/developer/orbs/orb/circleci/aws-eks Seems the build assets are missing for release v5.7.0, which results in a 404 from our build pipeline.

jshields avatar Apr 08 '22 20:04 jshields

FYI, this is breaking https://circleci.com/developer/orbs/orb/circleci/aws-eks Seems the build assets are missing for release v5.7.0, which results in a 404 from our build pipeline.

as a fallback, it seems that the orb has this property authenticator-release-tag, that you can use to set the previous release version of this lib

j-carvalho avatar Apr 08 '22 21:04 j-carvalho

This has happened before: https://github.com/kubernetes-sigs/aws-iam-authenticator/issues/344

milosivanovic avatar Apr 08 '22 21:04 milosivanovic

@j-carvalho I tried this, but it doesn't appear to make any difference and still fails (with a different error now - /bin/bash: line 13: v0.5.6: invalid variable name). Were you able to get it working? Here's what I added: https://github.com/CircleCI-Public/aws-eks-orb/issues/62#issuecomment-1093381864

milosivanovic avatar Apr 08 '22 21:04 milosivanovic

I just noticed that the v is hardcoded in the orb: v${VERSION} source: https://github.com/CircleCI-Public/aws-eks-orb/blob/6ca33e02f984ea02d6b37c974a9edc502e0a7c8a/src/scripts/install-aws-iam-authenticator.sh#L21

Edit: Looks like the v is already stripped here https://github.com/CircleCI-Public/aws-eks-orb/blob/6ca33e02f984ea02d6b37c974a9edc502e0a7c8a/src/scripts/install-aws-iam-authenticator.sh#L12 so it's not that.

Edit: Oh, it looks like the error I'm getting in CircleCI is different now: /bin/bash: line 13: v0.5.6: invalid variable name

milosivanovic avatar Apr 08 '22 22:04 milosivanovic

@milosivanovic We were able to get the release-tag working as well. We're using [email protected] and it works for us. Relevant bits from our circle config:

    steps:
      - kubernetes/install-kubectl: *kubectl-install-params
      - aws-eks/update-kubeconfig-with-authenticator:
          authenticator-release-tag: v0.5.6
          aws-region: $AWS_REGION
          cluster-name: << parameters.cluster-name >>
          install-kubectl: false

Docs on the circle site: https://circleci.com/developer/orbs/orb/circleci/aws-eks#commands-update-kubeconfig-with-authenticator

paulosman avatar Apr 08 '22 22:04 paulosman

It worked for me too.

authenticator-release-tag: "v0.5.6"

fm100 avatar Apr 08 '22 22:04 fm100

did not work for me, I am also getting /bin/bash: line 13: v0.5.6: invalid variable name

jacobleesinger avatar Apr 09 '22 02:04 jacobleesinger

can someone share the full config of circleci/aws-eks including the version? i'm using circleci/[email protected] and still getting invlaid variable name like many others....

wasims1 avatar Apr 09 '22 12:04 wasims1

Adding release tag v0.5.6 did not work for us as well. However, so we had to manually install aws-iam-authenticator:

      - run:
          command: |
            curl -o aws-iam-authenticator https://s3.us-west-2.amazonaws.com/amazon-eks/1.21.2/2021-07-05/bin/linux/amd64/aws-iam-authenticator
            chmod +x ./aws-iam-authenticator
            mkdir -p $HOME/bin && cp ./aws-iam-authenticator $HOME/bin/aws-iam-authenticator && export PATH=$PATH:$HOME/bin
            echo 'export PATH=$PATH:$HOME/bin' >> ~/.bashrc
            aws-iam-authenticator help
            curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/amd64/kubectl"
            sudo install -o root -g root -m 0755 kubectl /usr/local/bin/kubectl
            kubectl version --client

Add this before aws-eks/update-kubeconfig-with-authenticator step in circleci

russellraed avatar Apr 10 '22 01:04 russellraed

to anyone still having this issue, the aws-eks orb itself issued an emergency update just change the version to :2.1.2 and it should work for now...

wasims1 avatar Apr 10 '22 10:04 wasims1

@wasims1 that fixed it for me. Although I had to update some syntax since I were still on a beta version of that orb

johan-lejdung avatar Apr 10 '22 10:04 johan-lejdung

@wasims1 you've probably already fixed the issue, but try authenticator-release-tag: "0.5.6", it should work. 'Cause "v" letter is hard-coded in this job, check this var: DOWNLOAD_URL="https://github.com/kubernetes-sigs/aws-iam-authenticator/releases/download/v${VERSION}/${FILENAME}_${VERSION}_${PLATFORM}_amd64"

sartor1 avatar May 10 '22 05:05 sartor1

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 08 '22 06:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 07 '22 07:09 k8s-triage-robot

I'm going to assume this is fixed because I see assets on 0.5.7.

nckturner avatar Oct 04 '22 19:10 nckturner