aws-efs-csi-driver icon indicating copy to clipboard operation
aws-efs-csi-driver copied to clipboard

Add tags to dynamically created Access Points using YAML file

Open dheerajgss opened this issue 3 years ago • 6 comments

Is your feature request related to a problem? Please describe.

Whenever an access point is created dynamically using PV/PVC with the help of the EFS CSI driver, there are no tags associated with it to identify which PVC it belongs to (or) there is no way to add tags using the YAML file to categorize which pods/deployments are using those access points.

For example, if I want to use an access point with one of my application pods while creating a PVC for it, I want to tag that access point from the YAML file itself to know and notify other users that this particular access point is being used by this application pods/deployment.

Describe the solution you'd like in detail

Tweaking the YAML file definition to add the 'tags' parameter as well.

Describe alternatives you've considered

Open the AWS EFS console, search for the dynamically created access point, and then use the 'Manage Tags' option to add more tags. There is also the 'extraCreateMetadata' option which can be added to the helm chart, but it only provides static tags to all the access points created and does not support adding customized tags as per access point usage.

dheerajgss avatar May 10 '22 10:05 dheerajgss

Does #689 cover this?

jonathanrainer avatar May 10 '22 11:05 jonathanrainer

#689 partially covers the requirement, but if I want to categorize my access points in a much-refined way (like application level or pod level as mentioned in my initial description) then these static tags would not help me.

dheerajgss avatar May 10 '22 17:05 dheerajgss

Ah yes I see what you mean. Would you be happy to be able to set the tags per StorageClass? Or do you need it more fine grained than that?

jonathanrainer avatar May 10 '22 17:05 jonathanrainer

StorageClass settings would help I guess. I don't have any ideas about fine graining it as of now😅.

dheerajgss avatar May 10 '22 17:05 dheerajgss

Cool, I'll see if I can throw something together soon 😀

jonathanrainer avatar May 10 '22 17:05 jonathanrainer

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 08 '22 17:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 07 '22 18:09 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Oct 07 '22 18:10 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 07 '22 18:10 k8s-ci-robot