aws-efs-csi-driver icon indicating copy to clipboard operation
aws-efs-csi-driver copied to clipboard

Fix vulnerabilities in the release image

Open bouchardmathieu-qc opened this issue 3 years ago • 9 comments

This is a bug fix for the release image of EFS. Right now, multiple vulnerabilities are found in the container because there's know vulnerabilities in Kubernetes 1.22.1:

  • https://security.snyk.io/vuln/SNYK-GOLANG-K8SIOKUBERNETES-1585630
  • https://github.com/advisories/GHSA-f5f7-6478-qm6p

This pull request fixes several issues:

  • Upgrade Kubernetes dependencies to 1.22.2
  • Create a release image that doesn't have development tools installed by default
  • Always install the latest version of the amazon-efs-utils package from the yum repo (with the latest security updates)
  • Use curl (preinstalled) to download pip instead of installing wget to install pip

The final security scan was done with ECR scan (and Inspector2). The image was tested on an EKS cluster (version 1.21)

bouchardmathieu-qc avatar Mar 31 '22 16:03 bouchardmathieu-qc

CLA Not Signed

  • :x: - login: @bouchardmathieu-qc / name: Mathieu Bouchard . The commit (64660035d7906f517a595342261007d0b2f6aaa6, 0e809bf143457b2c417310e2b2e22f2315e7c15e, c24246819fb27b630e18b967c31a51cad0735215, 880972cda5f9c4c059416c5176cfcdd7d343b9e1) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

Welcome @bouchardmathieu-qc!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Mar 31 '22 16:03 k8s-ci-robot

Hi @bouchardmathieu-qc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 31 '22 16:03 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bouchardmathieu-qc To complete the pull request process, please assign jqmichael after the PR has been reviewed. You can assign the PR to them by writing /assign @jqmichael in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 31 '22 16:03 k8s-ci-robot

/ok-to-test /check-cla

wongma7 avatar Apr 05 '22 19:04 wongma7

@bouchardmathieu-qc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-efs-csi-driver-verify 880972cda5f9c4c059416c5176cfcdd7d343b9e1 link true /test pull-aws-efs-csi-driver-verify
pull-aws-efs-csi-driver-unit 880972cda5f9c4c059416c5176cfcdd7d343b9e1 link true /test pull-aws-efs-csi-driver-unit
pull-aws-efs-csi-driver-e2e 880972cda5f9c4c059416c5176cfcdd7d343b9e1 link true /test pull-aws-efs-csi-driver-e2e
pull-aws-efs-csi-driver-external-test-eks 880972cda5f9c4c059416c5176cfcdd7d343b9e1 link true /test pull-aws-efs-csi-driver-external-test-eks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Jun 15 '22 04:06 k8s-ci-robot

@bouchardmathieu-qc: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jun 15 '22 04:06 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 13 '22 05:09 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Oct 13 '22 05:10 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Nov 12 '22 06:11 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Nov 12 '22 06:11 k8s-ci-robot