aws-efs-csi-driver icon indicating copy to clipboard operation
aws-efs-csi-driver copied to clipboard

chore: Bump aws-sdk to 1.50 for EKS Pod Identity support

Open askulkarni2 opened this issue 1 year ago • 3 comments

Is this a bug fix or adding new feature? Fixes #1257. Bumps up aws-sdk-go to v1.50.3.

What is this PR about? / Why do we need it?

AWS SDK v.1.47.11 updated credential provider logic support which is required by pods which need to use the newly launched Amazon EKS Pod Identities.

Also see https://docs.aws.amazon.com/eks/latest/userguide/pod-id-minimum-sdk.html for further information.

What testing is done?

make and make test.

askulkarni2 avatar Jan 25 '24 00:01 askulkarni2

Welcome @askulkarni2!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jan 25 '24 00:01 k8s-ci-robot

Hi @askulkarni2. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 25 '24 00:01 k8s-ci-robot

@justinsb / @seanzatzdev-amazon any help to unblock this PR?

seshank-sk avatar Apr 04 '24 18:04 seshank-sk

/ok-to-test

aaroniscode avatar Apr 10 '24 15:04 aaroniscode

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: askulkarni2 Once this PR has been reviewed and has the lgtm label, please assign seanzatzdev-amazon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 19 '24 18:04 k8s-ci-robot