kubernetes-sigs
Update example-iam-policy.json
wildcard the aws partion field to prevent exclusion of partitions other than aws
Is this a bug fix or adding new feature? bug fix
What is this PR about? / Why do we need it?
we noticed that a similar change on the Terraform modules for AWS broke IaC deploys for partitions other than aws (like aws-us-gov for example)
What testing is done?
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @willswire!
It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @willswire. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Thank you for this @willswire!
Any contribution, even non-code changes, requires https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/2189#issuecomment-2419231039, but we will merge this in right afterwards.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for this @willswire!
Any contribution, even non-code changes, requires #2189 (comment), but we will merge this in right afterwards.
No problem - completed!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AndrewSirenko
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [AndrewSirenko]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment