about-api icon indicating copy to clipboard operation
about-api copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Updating ClusterProperty API to v1betav1

Open holgerson97 opened this issue 1 year ago • 7 comments

closes: https://github.com/kubernetes-sigs/about-api/issues/18

I upgrade the API files and adapted Makefile to support multiple CRD versions. Is there more required to do to close issue #18?

NOTE Since I updated controller-gen in a different PR this one should probably merged afterwards and manifest freshly generated with new version.

holgerson97 avatar Oct 21 '24 00:10 holgerson97

I am not sure if the About API is ready to move to v1beta1 yet. There are a bunch of properties that we would like to add.

ryanzhang-oss avatar Nov 05 '24 21:11 ryanzhang-oss

Thank you @holgerson97!!!! This is awesome!! I will catch up on these after Kubecon.

@ryanzhang-oss About API graduated to beta last year actually, but the repo hasn't caught up. Adding properties (if by that you mean, more records) is always possible; and well known properties can also be defined if that's what you mean.

lauralorenz avatar Nov 13 '24 18:11 lauralorenz

Let's do a rebase and regen soon since #26 is in and once #25 is in too

lauralorenz avatar Jan 31 '25 01:01 lauralorenz

@holgerson97 - now that #25 is merged, if you rebase I'll push this one through.

Thanks!

JeremyOT avatar Mar 18 '25 16:03 JeremyOT

Squashed and rebased. I always get the above notification saying I approved the changes, what do I need to do in order to not "approve" my PRs?

holgerson97 avatar Mar 21 '25 07:03 holgerson97

Triage notes: API users and lauralorenz@ for lgtm, @jermeyot for approve. Interested in merging and then opening new PR if there are specific things to clean up.

lauralorenz avatar May 13 '25 16:05 lauralorenz

Merging to keep things moving. @ryanzhang-oss I recommend a follow up PR for any scaffolding cleanup

/lgtm /approve

JeremyOT avatar May 13 '25 16:05 JeremyOT

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: holgerson97, JeremyOT

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 13 '25 16:05 k8s-ci-robot

cc @RainbowMango thanks for upgrading to v1beta1, but I thought we will keep the api in pkg/apis and generate client from there? For our use case, we will need the typed client.

qiujian16 avatar May 27 '25 02:05 qiujian16

Yes, seems we need another PR for the client thing.

RainbowMango avatar May 27 '25 03:05 RainbowMango