external-snapshotter icon indicating copy to clipboard operation
external-snapshotter copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-csi

is group snapshot feature fully implemented?

Open andyzhangx opened this issue 2 years ago • 5 comments

from this code snippet, it seem this feature is not fully implemented https://github.com/kubernetes-csi/external-snapshotter/blob/80a7aa9488ceb846e42298e09bbec04086686fdf/cmd/csi-snapshotter/main.go#L88-L89

but per https://kubernetes.io/blog/2023/05/08/kubernetes-1-27-volume-group-snapshot-alpha/#as-a-storage-vendor-how-do-i-add-support-for-group-snapshots-to-my-csi-driver, it's implemented

@xing-yang what's the status of this feature?

        // TODO(xing-yang): Enable enableVolumeGroupSnapshots when the feature is fully implemented
        // enableVolumeGroupSnapshots = flag.Bool("enable-volume-group-snapshots", false, "Enables the volume group snapshot feature, allowing the user to create snapshots of groups of volumes.")

andyzhangx avatar Nov 06 '23 07:11 andyzhangx

Create group snapshot is complete. The delete group snapshot part is still WIP.

xing-yang avatar Nov 06 '23 14:11 xing-yang

per this code snippet, I think this feature is not ready unless I hardcode this flag as true and recompile snapshot image:

https://github.com/kubernetes-csi/external-snapshotter/blob/80a7aa9488ceb846e42298e09bbec04086686fdf/cmd/csi-snapshotter/main.go#L232-L234

andyzhangx avatar Nov 06 '23 14:11 andyzhangx

A --enable-volume-group-snapshots option has been added in commit a574b8780ce8fa1d90d8ddca6fa7bf655336fd6e . Everything is in place for dynamic snapshotting. Importing pre-created group-snapshots is in progress through #837.

nixpanic avatar Nov 24 '23 16:11 nixpanic

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 22 '24 16:02 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Mar 23 '24 16:03 k8s-triage-robot

@xing-yang can this be closed as the group snapshot is fully implemented now?

Madhu-1 avatar Mar 25 '24 08:03 Madhu-1

--enable-volume-group-snapshots should be documented in README.

ChristianCiach avatar Jul 17 '24 13:07 ChristianCiach

Added an issue to track: https://github.com/kubernetes-csi/external-snapshotter/issues/1117

xing-yang avatar Jul 17 '24 13:07 xing-yang