external-snapshotter icon indicating copy to clipboard operation
external-snapshotter copied to clipboard

Fix volumesnapshot webhook-example RBAC rules

Open astraw99 opened this issue 3 years ago • 2 comments

What type of PR is this? /kind bug

What this PR does / why we need it: Adds RBAC volumesnapshots and volumesnapshotcontents to the validating webhook example, so that it can be deployed with proper access to the resources list/watch.

Does this PR introduce a user-facing change?:

NONE

astraw99 avatar May 28 '22 15:05 astraw99

Can you update the description with what was failing and how this change fixes the issue?

RaunakShah avatar May 30 '22 07:05 RaunakShah

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: astraw99 Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval by writing /assign @jsafrane in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 29 '22 17:08 k8s-ci-robot