external-snapshotter icon indicating copy to clipboard operation
external-snapshotter copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-csi

YAML manifests should have multiple document delimiter

Open tsunny opened this issue 4 years ago • 3 comments

Found document delimiter(---) missing in few manifests. This causes malformed YAML when loading it in ruby.

Files with missing document delimiter:

  • https://github.com/kubernetes-csi/external-snapshotter/blob/master/deploy/kubernetes/csi-snapshotter/rbac-csi-snapshotter.yaml#L11
  • https://github.com/tsunny/external-snapshotter/blob/master/deploy/kubernetes/csi-snapshotter/rbac-external-provisioner.yaml#L11
  • https://github.com/kubernetes-csi/external-snapshotter/blob/v3.0.3/deploy/kubernetes/snapshot-controller/rbac-snapshot-controller.yaml#L8
  • https://github.com/kubernetes-csi/external-snapshotter/blob/v3.0.3/deploy/kubernetes/webhook-example/webhook.yaml#L1

tsunny avatar Dec 17 '20 21:12 tsunny

technically not needed since they are single resources, but nice for consistency 👍

grosser avatar Dec 17 '20 22:12 grosser

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

fejta-bot avatar Mar 17 '21 22:03 fejta-bot

/lifecycle frozen

grosser avatar Mar 17 '21 22:03 grosser