external-health-monitor icon indicating copy to clipboard operation
external-health-monitor copied to clipboard

Upgrade CSI-Spec to v1.10.0 with csi-test v3.5.1 protobuf fixes

Open AndrewSirenko opened this issue 1 year ago • 6 comments

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake

/cleanup

What this PR does / why we need it:

Bump csi-spec to v1.10.0 with csi-test v3.5.1 protobuf fixes for breaking changes

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

AndrewSirenko avatar Aug 27 '24 20:08 AndrewSirenko

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrewSirenko Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 27 '24 20:08 k8s-ci-robot

/test pull-kubernetes-csi-external-health-monitor

AndrewSirenko avatar Aug 27 '24 20:08 AndrewSirenko

/hold

CSI Spec release must be cut with new Protobuf Matcher.

AndrewSirenko avatar Aug 27 '24 20:08 AndrewSirenko

/test pull-kubernetes-csi-external-health-monitor

AndrewSirenko avatar Aug 27 '24 20:08 AndrewSirenko

/test pull-kubernetes-csi-external-health-monitor

AndrewSirenko avatar Aug 27 '24 20:08 AndrewSirenko

/CC @jsafrane

Revised this to use released version of csi-test v5.3.1

AndrewSirenko avatar Sep 24 '24 15:09 AndrewSirenko

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Nov 06 '24 01:11 k8s-ci-robot

@AndrewSirenko This PR can be closed?

xing-yang avatar Dec 18 '24 15:12 xing-yang