csi-release-tools icon indicating copy to clipboard operation
csi-release-tools copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-csi

Enable the VolumeGroupSnapshot tests

Open Phaow opened this issue 2 months ago • 12 comments

What type of PR is this? /kind test

What this PR does / why we need it:

  • Enable the VolumeGroupSnapshot tests. Used the temporary job for vgs pull-kubernetes-e2e-storage-kind-vgs verified it works as expected in live PR.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Phaow avatar Sep 30 '25 09:09 Phaow

/test pull-kubernetes-csi-release-tools-csi-test

Phaow avatar Sep 30 '25 11:09 Phaow

Hi @xing-yang @jsafrane @gnufied @msau42 , could you please help review when you get a chance? Thank you!

Phaow avatar Sep 30 '25 11:09 Phaow

/assign @xing-yang @jsafrane @gnufied @msau42

Phaow avatar Sep 30 '25 11:09 Phaow

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Phaow Once this PR has been reviewed and has the lgtm label, please ask for approval from jsafrane. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 01 '25 14:10 k8s-ci-robot

/label tide/merge-method-squash

Phaow avatar Oct 01 '25 14:10 Phaow

Hi @jsafrane , could you help take a look again when you get a chance? Thank you! I hack some codes in https://github.com/kubernetes-csi/csi-release-tools/compare/master...Phaow:csi-release-tools:dev and verify it works, which needs update in job definition part, the script also needs the https://github.com/kubernetes-csi/csi-release-tools/blob/master/filter-junit.go, I will download it in prow job definition part.

Phaow avatar Oct 10 '25 08:10 Phaow

/test pull-kubernetes-csi-release-tools-external-provisioner

Phaow avatar Oct 13 '25 02:10 Phaow

/test pull-kubernetes-csi-release-tools-external-provisioner

Phaow avatar Oct 13 '25 05:10 Phaow

@Phaow Sorry if you answered this already, but why aren't we implementing this via - https://github.com/kubernetes-csi/external-snapshotter/blob/master/.prow.sh ? Is that not doable?

gnufied avatar Oct 23 '25 14:10 gnufied

Hi @gnufied , thanks for looking into this, we have a discussion try to use it also for k/k vgs testing -> https://kubernetes.slack.com/archives/C8EJ01Z46/p1758723200461749

Phaow avatar Oct 23 '25 14:10 Phaow

Hi @gnufied , could you help take a look again when you get a chance? Thank you! ^^

Phaow avatar Nov 04 '25 14:11 Phaow

/lgtm

gnufied avatar Nov 04 '25 21:11 gnufied

Hi @jsafrane , could you help take a review again when you get a chance? Thank you! ^^

Phaow avatar Nov 05 '25 10:11 Phaow