csi-release-tools
csi-release-tools copied to clipboard
kubernetes-csi
Remove --kube-root deprecated kind argument
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The --kube-root flag has been deprecated in kind for some time and will be removed. The current equivalent functionality is to pass the path to the kubernetes source as the first non-flag argument to build node-image.
This updates the prow script to use the newer preferred method in preparation for kind dropping the flag.
Which issue(s) this PR fixes:
Related: https://github.com/kubernetes-sigs/kind/issues/3717
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
Welcome @stmcginnis!
It looks like this is your first PR to kubernetes-csi/csi-release-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-csi/csi-release-tools has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @stmcginnis. Thanks for your PR.
I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Test failures do not look related:
ERROR: go module files *not* up-to-date, they did get modified by 'GO111MODULE=on go mod tidy':
diff --git a/go.mod b/go.mod
[snip]
diff --git a/go.sum b/go.sum
[snip]
Looks like maybe a side effect of an updated test runner environment?
@TerryHowe: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
CI for this repo appears to be broken for awhile now. https://github.com/kubernetes-csi/csi-release-tools/pull/259#issuecomment-2299112766
This https://github.com/kubernetes-csi/csi-test/pull/560 may resolve the broken tests
Rebased on master. Not sure if the CI issues are fixed yet or not, so wanted to get fresh results.
Folks: At some point I'm just going to delete this deprecated flag from kind anyhow, we are doing our best to help projects prepare. Please take a look.
@stmcginnis: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-kubernetes-csi-release-tools-csi-test | faf79ff66f424d575962573f22322e339d4bb90e | link | false | /test pull-kubernetes-csi-release-tools-csi-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/lgtm /approve
The pull-kubernetes-csi-release-tools-csi-test failure will get fixed by https://github.com/kubernetes-csi/csi-test/pull/561.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: pohly, stmcginnis, TerryHowe
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [pohly]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment