Authentication with Kerberos credentials
What type of PR is this?
/kind feature
What this PR does / why we need it: This PR implements authentication with a kerberos principal and password when mounting NFS shares.
Which issue(s) this PR fixes:
Fixes #525
Special notes for your reviewer:
- I changed the Dockerfile's base image to
debian:stable-slimJustification: services cannot be started due to a missing file/lib/lsb/init-functions - I changed the Dockerfile's entrypoint to a script (
entry.sh) The script is created in the Dockerfile inline, and you can review it here Justification: this is so we can start necessary services (rpcbindandnfs-common) if and only if we're in the controller pod. Otherwise, thenfspluginbinary is invoked with the exact same arguments the pod'snfscontainer was started with.
Does this PR introduce a user-facing change?:
Added the ability to authenticate with kerberos-protected NFS shares
The following new parameters may be specified when creating or updating a storage class:
- **`authPrincipal`**
The principal that will be used to authenticate to the share
- **`authPasswordSecret`**
The secret containing the authentication password
- **`authKrbConf`**
The secret containing contents of a krb5.conf with information about how to connect to a realm.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: GamerGirlandCo Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @GamerGirlandCo!
It looks like this is your first PR to kubernetes-csi/csi-driver-nfs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-csi/csi-driver-nfs has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: GamerGirlandCo / name: ☙◦ The Tablet ❀ GamerGirlandCo ◦❧ (13221c1916c2d348856d0f8947dfb07d78217e02, 16b2aa7bf9209463b188effdf1ec724535d79ff7, 250ff6d4372cd2865cffe745402dae385e60c1cc, 2a4e0cdefbafa9aa7c1d192f4efdef8ec4fcead9, 41ead104bdbf2344ce0c775cbb7c48c4380fe0f4, 530c840591dc38ae5dc01cb012ccced240aa5e2c, 714dfa5bfeda4fc2571f26a926eb8e33eaabca8e, 8a474caac116e9b09a3aee1a0b01a92f62f639d9, 8c629801cdbd0a05feaa2e80b23cd9ae36e529a4, 903cfea45b84fd6545aafba3262c23cf2ececac2, a3003d7dc1f8fd11b7f10a99344f51871c846e6b, a6e1f3372958c1385391d53e471e1ca9a6701a6a, ab4a8636f653d0b44c0ffdbfaad89dbe8b232145, ae1b082acbc84ce62f052f1ae7a5e7192c44409f, afbbd54d3112becba85ad1c3be3acc81bba68e56, c377d73bcba09df8cf69b5b2b4b8ce419c646fd8, c466707f8addcc05b183d9af6780bfe2cd5124e5, c72a7fe9a2f4de0d3bd70f8881c9d9ade371025b, d615d7f0911f33cfec6bc72fc8e51b1d9ca7af1f, dd802252f9ea64a4d04d21903f55ded9aff33969, ed9596aee232536ac0084ca4658a185e597d5b12, f29f24c908fdc0d8d72514aa38e456a50c7f3102, f63481829d10f266f2324087015c4b02e07aba23, f9351ae439543023c54d0bdc3ae626fd11fd5ced)
Hi @GamerGirlandCo. Thanks for your PR.
I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest
/retest
/retest
/test pull-csi-driver-nfs-e2e-capz
/retest-required
@GamerGirlandCo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-csi-driver-nfs-e2e-capz | a3003d7dc1f8fd11b7f10a99344f51871c846e6b | link | unknown | /test pull-csi-driver-nfs-e2e-capz |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.