csi-driver-nfs icon indicating copy to clipboard operation
csi-driver-nfs copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-csi

chore: update kube dependencies to v1.24.0

Open humblec opened this issue 3 years ago • 7 comments

Signed-off-by: Humble Chirammal [email protected]

/kind cleanup

-->

Kube dependencies are updated to v1.24.0.

humblec avatar May 06 '22 13:05 humblec

Pull Request Test Coverage Report for Build 2468367597

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.575%
Totals Coverage Status
Change from base Build 2462377990: 0.0%
Covered Lines: 559
Relevant Lines: 730
💛 - Coveralls

coveralls avatar May 06 '22 14:05 coveralls

/test pull-csi-driver-nfs-e2e

humblec avatar May 06 '22 14:05 humblec

seems the e2e tests need to be changed with this k8s lib changes:

 error waiting for deployment "nfs-volume-tester-fr9zl" status to match expectation: deployment status: v1.DeploymentStatus{ObservedGeneration:1, Replicas:0, UpdatedReplicas:0, ReadyReplicas:0, AvailableReplicas:0, UnavailableReplicas:1, Conditions:[]v1.DeploymentCondition{v1.DeploymentCondition{Type:"Progressing", Status:"True", LastUpdateTime:time.Date(2022, time.May, 6, 15, 13, 14, 0, time.Local), LastTransitionTime:time.Date(2022, time.May, 6, 15, 13, 14, 0, time.Local), Reason:"NewReplicaSetCreated", Message:"Created new replica set \"nfs-volume-tester-fr9zl-947674b7\""}, v1.DeploymentCondition{Type:"Available", Status:"False", LastUpdateTime:time.Date(2022, time.May, 6, 15, 13, 14, 0, time.Local), LastTransitionTime:time.Date(2022, time.May, 6, 15, 13, 14, 0, time.Local), Reason:"MinimumReplicasUnavailable", Message:"Deployment does not have minimum availability."}, v1.DeploymentCondition{Type:"ReplicaFailure", Status:"True", LastUpdateTime:time.Date(2022, time.May, 6, 15, 13, 14, 0, time.Local), LastTransitionTime:time.Date(2022, time.May, 6, 15, 13, 14, 0, time.Local), Reason:"FailedCreate", Message:"pods \"nfs-volume-tester-fr9zl-947674b7-kl59j\" is forbidden: violates PodSecurity \"restricted:latest\": allowPrivilegeEscalation != false (container \"volume-tester\" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container \"volume-tester\" must set securityContext.capabilities.drop=[\"ALL\"]), runAsNonRoot != true (pod or container \"volume-tester\" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container \"volume-tester\" must set securityContext.seccompProfile.type to \"RuntimeDefault\" or \"Localhost\")"}}, CollisionCount:(*int32)(nil)}

andyzhangx avatar May 07 '22 02:05 andyzhangx

seems the e2e tests need to be changed with this k8s lib changes:

 error waiting for deployment "nfs-volume-tester-fr9zl" status to match expectation: deployment status: v1.DeploymentStatus{ObservedGeneration:1, Replicas:0, UpdatedReplicas:0, ReadyReplicas:0, AvailableReplicas:0, UnavailableReplicas:1, Conditions:[]v1.DeploymentCondition{v1.DeploymentCondition{Type:"Progressing", Status:"True", LastUpdateTime:time.Date(2022, time.May, 6, 15, 13, 14, 0, time.Local), LastTransitionTime:time.Date(2022, time.May, 6, 15, 13, 14, 0, time.Local), Reason:"NewReplicaSetCreated", Message:"Created new replica set \"nfs-volume-tester-fr9zl-947674b7\""}, v1.DeploymentCondition{Type:"Available", Status:"False", LastUpdateTime:time.Date(2022, time.May, 6, 15, 13, 14, 0, time.Local), LastTransitionTime:time.Date(2022, time.May, 6, 15, 13, 14, 0, time.Local), Reason:"MinimumReplicasUnavailable", Message:"Deployment does not have minimum availability."}, v1.DeploymentCondition{Type:"ReplicaFailure", Status:"True", LastUpdateTime:time.Date(2022, time.May, 6, 15, 13, 14, 0, time.Local), LastTransitionTime:time.Date(2022, time.May, 6, 15, 13, 14, 0, time.Local), Reason:"FailedCreate", Message:"pods \"nfs-volume-tester-fr9zl-947674b7-kl59j\" is forbidden: violates PodSecurity \"restricted:latest\": allowPrivilegeEscalation != false (container \"volume-tester\" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container \"volume-tester\" must set securityContext.capabilities.drop=[\"ALL\"]), runAsNonRoot != true (pod or container \"volume-tester\" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container \"volume-tester\" must set securityContext.seccompProfile.type to \"RuntimeDefault\" or \"Localhost\")"}}, CollisionCount:(*int32)(nil)}

sure, will correct that.. its on PS feature gate afacit.

humblec avatar May 09 '22 04:05 humblec

so it looks like for e2e to pass, either the PS feature gate has to be false or we need to annotate the e2e namespace to have labels .

kubectl label --overwrite ns <E2E namespace >\
  pod-security.kubernetes.io/enforce=privileged \
  pod-security.kubernetes.io/warn=baseline \
  pod-security.kubernetes.io/audit=baseline

@andyzhangx any thoughts here?

humblec avatar May 31 '22 15:05 humblec

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: humblec Once this PR has been reviewed and has the lgtm label, please assign saad-ali for approval by writing /assign @saad-ali in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 22 '22 15:09 k8s-ci-robot

@humblec: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-csi-driver-nfs-unit 0fc5f2bed41cf0c0269e34ec303e8aabe6a3137f link true /test pull-csi-driver-nfs-unit
pull-csi-driver-nfs-integration 0fc5f2bed41cf0c0269e34ec303e8aabe6a3137f link true /test pull-csi-driver-nfs-integration
pull-csi-driver-nfs-sanity 0fc5f2bed41cf0c0269e34ec303e8aabe6a3137f link true /test pull-csi-driver-nfs-sanity
pull-kubernetes-csi-csi-driver-nfs 0fc5f2bed41cf0c0269e34ec303e8aabe6a3137f link true /test pull-kubernetes-csi-csi-driver-nfs
pull-csi-driver-nfs-external-e2e 0fc5f2bed41cf0c0269e34ec303e8aabe6a3137f link true /test pull-csi-driver-nfs-external-e2e
pull-csi-driver-nfs-e2e 0fc5f2bed41cf0c0269e34ec303e8aabe6a3137f link true /test pull-csi-driver-nfs-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Sep 22 '22 15:09 k8s-ci-robot

@humblec: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 18 '22 06:10 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: humblec Once this PR has been reviewed and has the lgtm label, please assign saad-ali for approval by writing /assign @saad-ali in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 24 '22 20:10 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 22 '23 20:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Feb 21 '23 21:02 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Feb 21 '23 22:02 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Mar 23 '23 23:03 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 23 '23 23:03 k8s-ci-robot