kubernetes-client
fix Issue #2418: parse_rfc3339 calling .groups() on None
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes a runtime bug in parse_rfc3339() where the function would call .groups() on a None result if the regex did not match. Previously caused AttributeError: 'NoneType' object has no attribute 'groups'
Which issue(s) this PR fixes:
Fixes #2418
Special notes for your reviewer:
Includes unit test test_2_parse_rfc3339 with malformed datetime strings to verify fix and prevent regressions.
Does this PR introduce a user-facing change?
Improved RFC3339 datetime parsing logic in kube config loading. Invalid strings now raise a descriptive
ValueError instead of a raw AttributeError.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
NA
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: omavashia2005 Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @omavashia2005!
It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-client/python has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.