python
python copied to clipboard
kubernetes-client
feat: populate cluster config from client.authentication.k8s.io/exec …
What type of PR is this?
/kind bug
What this PR does / why we need it:
populate ExecCredentialSpec.Cluster.config from the client.authentication.k8s.io/exec extension
Which issue(s) this PR fixes:
Fixes #2395
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Adds cluster config information to the exec credential provider if the client.authentication.k8s.io/exec extension is provided.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Recreating PR since https://github.com/kubernetes-client/python/pull/2396 has CLA issues. Credits go to @wkloucek
Welcome @ma-ts!
It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-client/python has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
@fabianfv @yliaog Any comments about this PR? Would be nice if we can release this, so that clusters using these extensions can be managed with this library.
Also fixes some big issues on the Azure CLI managing these clusters from Azure.
@yliaog: Closed this PR.
In response to this:
/close
will reopen to trigger CI
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@yliaog: Reopened this PR.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ma-ts, yliaog
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~kubernetes/base/OWNERS~~ [yliaog]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment