python icon indicating copy to clipboard operation
python copied to clipboard

populate cluster config from client.authentication.k8s.io/exec extension

Open wkloucek opened this issue 7 months ago • 7 comments

What type of PR is this?

/kind bug

What this PR does / why we need it:

populate ExecCredentialSpec.Cluster.config from the client.authentication.k8s.io/exec extension

Which issue(s) this PR fixes:

Fixes #2395

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds cluster config information to the exec credential provider if the client.authentication.k8s.io/exec extension is provided.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


wkloucek avatar May 14 '25 08:05 wkloucek

CLA Not Signed

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wkloucek Once this PR has been reviewed and has the lgtm label, please assign roycaihw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 14 '25 08:05 k8s-ci-robot

Welcome @wkloucek!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar May 14 '25 08:05 k8s-ci-robot

Please sign the CLA. Also please add a unit test for this.

roycaihw avatar May 14 '25 14:05 roycaihw

Hi! Can this be implemented? @wkloucek: if the CLA is prohibited by your organisation, more than happy to re-contribute from our organisation.

Merging this also fixes issues with the Azure CLI, connecting on-prem clusters to Azure (see https://github.com/Azure/azure-cli-extensions/issues/8788).

Validated that this fixes the issue there as well (by patching the function call manually)

ma-ts avatar May 24 '25 06:05 ma-ts

Hi! Can this be implemented? @wkloucek: if the CLA is prohibited by your organisation, more than happy to re-contribute from our organisation.

I'm currently waiting for my company to register for the CLA. I didn't hear back how long it's gonna take though

wkloucek avatar May 24 '25 07:05 wkloucek

Can I republish? More than happy to give you all credits

ma-ts avatar May 24 '25 14:05 ma-ts

Unfortunately, I couldn't get the CLA setup so far. Also meanwhile this is not needed any longer on my side.

@ma-ts already picked those changes up in https://github.com/kubernetes-client/python/pull/2399, therefore I'm gonna close here

wkloucek avatar Jul 14 '25 08:07 wkloucek