fix: bumped up [at]types/tar to fix the error TS2709: Cannot use namespace 'MiniPass' as a type

[zhaow-de]

For my application with dependencies:

{
  "dependencies": {
    "@kubernetes/client-node": "^0.17.0",
    "aws-sdk": "^2.1181.0",
    "dotenv": "^16.0.1",
    "request": "^2.88.2",
    "request-promise": "^4.2.6",
    "winston": "^3.8.1"
  },
  "devDependencies": {
    "@types/jest": "^28.1.6",
    "@types/request": "^2.48.8",
    "@types/request-promise": "^4.1.48",
    "core-js": "^3.24.0",
    "jest": "^28.1.3",
    "jest-coverage-badges": "^1.1.2",
    "nock": "^13.2.9",
    "ts-jest": "^28.0.7",
    "typemoq": "^2.1.0",
    "typescript": "^4.7.4"
  }
}

npx tsc is failing because:

node_modules/@types/tar/index.d.ts:252:36 - error TS2709: Cannot use namespace 'MiniPass' as a type.
252 export interface ReadEntry extends MiniPass, HeaderProperties {
                                       ~~~~~~~~
Found 1 error in node_modules/@types/tar/index.d.ts:252

Bumping up the version of @types/tar from 4.x to 6.x matching tar and added explicit dependency to minipass solve the problem.

Refer to https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/60901?sort=top#discussioncomment-3217607

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: zhaow-de / name: Zhao Wang (41394d1736fafa0639cfa78036eef5250b1d95ee)

[k8s-ci-robot]

Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request.

You can edit the title by writing /retitle in a comment.

When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhaow-de Once this PR has been reviewed and has the lgtm label, please assign brendandburns for approval by writing /assign @brendandburns in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @zhaow-de!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

• 41394d1 fix: bumped up @types/tar to fix the error TS2709: Cannot use namespace 'MiniPass' as a type
• 8416778 fix: explicitly added minipass to the dependency to override the unnecessary @types/minipass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[brendandburns]

Hrm, since that is a transitive dependency of the tar package, I'm not sure why we need to add this dependency? Shouldn't it be a dependency of tar?

[k8s-ci-robot]

@zhaow-de: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yotamselementor]

This #847 should fix this issue - I moved the problematic dependencies to devDependencies. If anyone could create a new release, it would be great. Maybe @brendandburns could help out here.

[alvesalex]

This #847 should fix this issue - I moved the problematic dependencies to devDependencies. If anyone could create a new release, it would be great. Maybe @brendandburns could help out here.

I appreciate if we get a new release for 0.15.x as well.

[skhaz]

I am having this issue

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[yotamselementor]

/remove-lifecycle stale

[brendandburns]

Closing this since #924 merged and provides the same bump.