java
java copied to clipboard
Patching in code generation workflow doesn't work
https://github.com/kubernetes-client/java/actions/runs/13120437178
When I just ran the openapi model generation workflow just now, an error from code patching step aborted the workflow with following error:
Run ls scripts/patches/*.diff | xargs git apply
error: patch failed: kubernetes/src/main/java/io/kubernetes/client/openapi/models/V1Secret.java:18
error: kubernetes/src/main/java/io/kubernetes/client/openapi/models/V1Secret.java: patch does not apply
So I had skip the code patch step in the workflow via, retry and toggling If true, skip patching code after generation: https://github.com/kubernetes-client/java/actions/runs/13120777699
This indicates that the patches under scripts/patches folder are outdated, hence we need to do either of:
- Refresh the patch files for the branch
- Consider an alternative approach to make incremental patches on top of the raw generated code.
https://github.com/kubernetes-client/java/actions/runs/13120777699/job/36605935886
The retry attempt failed again due to failing to open a pull request.. I'm going to run it in my fork repo
Yeah, I think we need a better way to approach the automation with the patching involved. Not sure I have any great ideas though.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle stale - Close this issue with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle rotten - Close this issue with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Reopen this issue with
/reopen - Mark this issue as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
@k8s-triage-robot: Closing this issue, marking it as "Not Planned".
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied- After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied- After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closedYou can:
- Reopen this issue with
/reopen- Mark this issue as fresh with
/remove-lifecycle rotten- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.