java icon indicating copy to clipboard operation
java copied to clipboard

Patching in code generation workflow doesn't work

Open yue9944882 opened this issue 9 months ago • 4 comments
trafficstars

https://github.com/kubernetes-client/java/actions/runs/13120437178

When I just ran the openapi model generation workflow just now, an error from code patching step aborted the workflow with following error:

Run ls scripts/patches/*.diff | xargs git apply
error: patch failed: kubernetes/src/main/java/io/kubernetes/client/openapi/models/V1Secret.java:18
error: kubernetes/src/main/java/io/kubernetes/client/openapi/models/V1Secret.java: patch does not apply

So I had skip the code patch step in the workflow via, retry and toggling If true, skip patching code after generation: https://github.com/kubernetes-client/java/actions/runs/13120777699

This indicates that the patches under scripts/patches folder are outdated, hence we need to do either of:

  1. Refresh the patch files for the branch
  2. Consider an alternative approach to make incremental patches on top of the raw generated code.

yue9944882 avatar Feb 03 '25 19:02 yue9944882

https://github.com/kubernetes-client/java/actions/runs/13120777699/job/36605935886

The retry attempt failed again due to failing to open a pull request.. I'm going to run it in my fork repo

yue9944882 avatar Feb 03 '25 19:02 yue9944882

Yeah, I think we need a better way to approach the automation with the patching involved. Not sure I have any great ideas though.

brendandburns avatar Feb 04 '25 22:02 brendandburns

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 05 '25 23:05 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jun 05 '25 00:06 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Jul 05 '25 00:07 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jul 05 '25 00:07 k8s-ci-robot