java icon indicating copy to clipboard operation
java copied to clipboard

Update pom.xml - com.bucket4j migration

Open danielburrell opened this issue 1 year ago • 3 comments
trafficstars

The groupId com.github.vladimir-bukhtoyarov has migrated to com.bucket4j see https://mvnrepository.com/artifact/com.github.vladimir-bukhtoyarov/bucket4j-core/8.0.1

Note: I have not upgraded the version (there are newer versions). This is to allow this to be a like-for-like replacement.

Once this migration is made, dependabot will be able to see the newer versions and propose future upgrades.

danielburrell avatar Jul 03 '24 20:07 danielburrell

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: danielburrell / name: Daniel Burrell (517f7a6e84b49940ef6fb28c2791e7318b119adf, d002f4279d6ec5bd748f998ef7bd411b6ee67da6)

Welcome @danielburrell!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jul 03 '24 20:07 k8s-ci-robot

@brendandburns / @yue9944882 do you have an ETA for when this can be reviewed?

thank you in advance

danielburrell avatar Jul 08 '24 09:07 danielburrell

/lgtm /approve

brendandburns avatar Jul 08 '24 16:07 brendandburns

~~Sorry, I missed, com.github.vladimir-bukhtoyarov in the extended pom (didn't realise that existed). Will correct and revert shortly.~~

Ready!

danielburrell avatar Jul 08 '24 17:07 danielburrell

@brendandburns my apologies for the misfire, can we retry?

danielburrell avatar Jul 08 '24 19:07 danielburrell

/lgtm /approve

brendandburns avatar Jul 10 '24 16:07 brendandburns

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, danielburrell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jul 10 '24 16:07 k8s-ci-robot