java icon indicating copy to clipboard operation
java copied to clipboard

Fix NetworkingV1Api.java Patch

Open roshandash411 opened this issue 1 year ago • 4 comments
trafficstars

The patchingress is broken in 1.20 version. So raised a fix for it. Even the open api spec mentions about using "application/json-patch+json", "application/merge-patch+json", "application/strategic-merge-patch+json", "application/apply-patch+yaml"

roshandash411 avatar Mar 30 '24 21:03 roshandash411

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: roshandash411 / name: Roshan Dash (ad578d60a5571c30108665c935a950accc86b536)

Welcome @roshandash411!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Mar 30 '24 21:03 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: roshandash411 Once this PR has been reviewed and has the lgtm label, please assign brendandburns for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 30 '24 21:03 k8s-ci-robot

close and re-open to trigger CI job

yue9944882 avatar May 27 '24 18:05 yue9944882

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 25 '24 18:08 k8s-triage-robot

Closing this PR, because the right solution here is to use PatchUtils.java

brendandburns avatar Sep 13 '24 14:09 brendandburns