java icon indicating copy to clipboard operation
java copied to clipboard

fix for NO_EXECUTE toString Method

Open priyal13m opened this issue 3 years ago • 4 comments
trafficstars

  • fixed spelling mistake in NO_EXECUTE toString Method.
  • added unit tests for NO_EXECUTE toString Method

Fixes #2340

priyal13m avatar Aug 16 '22 08:08 priyal13m

Welcome @priyal13m!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Aug 16 '22 08:08 k8s-ci-robot

/lgtm /approve

Thanks for the PR!

brendandburns avatar Aug 16 '22 21:08 brendandburns

/approve

brendandburns avatar Aug 17 '22 15:08 brendandburns

/lgtm

brendandburns avatar Aug 17 '22 15:08 brendandburns

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, priyal13m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 17 '22 15:08 k8s-ci-robot

@brendandburns - This is my first PR and need some guidance here. Java 11.0.x Maven Test on windows-latest failed for -

Error: testSimpleRateLimitQueue(io.kubernetes.client.extended.workqueue.DefaultRateLimitQueueTest) Time elapsed: 0.518 s <<< FAILURE!

priyal13m avatar Aug 17 '22 16:08 priyal13m

@priyal13m: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 18 '22 03:08 k8s-ci-robot