java icon indicating copy to clipboard operation
java copied to clipboard

Add support for dynamic objects to kubectl apply.

Open brendandburns opened this issue 3 years ago • 4 comments
trafficstars

Addresses #2318 (I think)

@yue9944882 this is a sketch, let me know if you think it looks ok and I will add tests.

brendandburns avatar Jul 22 '22 15:07 brendandburns

@yue9944882 updated per your comment. Please take another look. Once this looks good, I can add tests.

brendandburns avatar Jul 25 '22 19:07 brendandburns

@brendandburns overall looks good, lets add some tests. (and fix the format)

yue9944882 avatar Jul 28 '22 08:07 yue9944882

Ok, I wrote tests and fixed formatting, this is ready for final review.

Thanks!

brendandburns avatar Aug 12 '22 21:08 brendandburns

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 18 '22 10:08 k8s-ci-robot