csharp icon indicating copy to clipboard operation
csharp copied to clipboard

Enable JSON Patch in AOT

Open hwoodiwiss opened this issue 1 year ago • 4 comments

Updates KubernetesJson.Serialize with a special case for seializing V1Patch when the content is string, as based on the examples and the converter implementation, the expectation in this case is that the conent already be JSON.

fixes #1587

hwoodiwiss avatar Sep 18 '24 19:09 hwoodiwiss

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: hwoodiwiss / name: Hugo Woodiwiss (05ed1f35966e625d1c45f246df303d5cb03a651f, 1eb62a85893919df989b38b7df0ec8e1aea93993)

Welcome @hwoodiwiss!

It looks like this is your first PR to kubernetes-client/csharp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/csharp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Sep 18 '24 19:09 k8s-ci-robot

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@541abb0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/KubernetesClient.Aot/KubernetesJson.cs 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1588   +/-   ##
=========================================
  Coverage          ?   61.43%           
=========================================
  Files             ?      103           
  Lines             ?     3073           
  Branches          ?      642           
=========================================
  Hits              ?     1888           
  Misses            ?     1185           
  Partials          ?        0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 27 '24 16:09 codecov-commenter

/LGTM

tg123 avatar Nov 04 '24 23:11 tg123

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hwoodiwiss, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 05 '24 05:11 k8s-ci-robot