machine-controller icon indicating copy to clipboard operation
machine-controller copied to clipboard

feat(kubevirt): configure runStrategy

Open oliverbaehler opened this issue 1 year ago • 2 comments

Hi. more like a question:

Is there a specific reason this is hard-coded to RunOnce for the kubevirt probvider?

RunStrategy: &runStrategyOnce,

There's other strategies available: https://pkg.go.dev/kubevirt.io/api/core/v1#VirtualMachineRunStrategy

I guess it makes sense as default, but consider this: If a kubevirt host dives (restarts) all the kubermatic VMIs do not restart (unless you live-migrate to another host, if there's another available). Would it be possible to make this field configurable via machineTemplate? The default can still be RunOnce, but eg. in our use-case we would prefer to use RerunOnFailure

oliverbaehler avatar Jul 05 '24 13:07 oliverbaehler

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubermatic-bot avatar Oct 03 '24 14:10 kubermatic-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubermatic-bot avatar Nov 03 '24 00:11 kubermatic-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubermatic-bot avatar Dec 03 '24 00:12 kubermatic-bot

@kubermatic-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubermatic-bot avatar Dec 03 '24 00:12 kubermatic-bot