machine-controller
machine-controller copied to clipboard
restart containerd for flatcar so the drop in conf will be considered
Signed-off-by: Luca Kuendig [email protected]
What this PR does / why we need it: I noticed, that during the first boot of a Flatcar node custom configurations, like containerd custom registry endpoint and auth, will not be used. I think it is because compared to other operatingsystems Flatcar allready has containerd installed and starts it directly after boot, so systemctl enable --now does nothing. By restarting the containerd service instead of systemctl enable (should be enabled by default) The config will be picked up on the first boot.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
NONE
Documentation:
NONE
Hi @lucakuendig. Thanks for your PR.
I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test
@lucakuendig the fixture data needs to be updated. Please run the script hack/update-fixtures.sh.
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ahmedwaleedmalik, lucakuendig
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [ahmedwaleedmalik]
- ~~pkg/userdata/OWNERS~~ [ahmedwaleedmalik]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment