machine-controller icon indicating copy to clipboard operation
machine-controller copied to clipboard

Read and load .env files

Open kron4eg opened this issue 3 years ago • 3 comments

What this PR does / why we need it: To make it easier to work with environment variables. Also it's a precursor for integrating with vault without integrating anything.

What type of PR is this? /kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

Read and load .env files

Documentation:

NONE

kron4eg avatar Oct 14 '22 09:10 kron4eg

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kron4eg Once this PR has been reviewed and has the lgtm label, please assign ahmedwaleedmalik for approval by writing /assign @ahmedwaleedmalik in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubermatic-bot avatar Oct 14 '22 09:10 kubermatic-bot

/retest

kron4eg avatar Oct 14 '22 09:10 kron4eg

@kron4eg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-license-validation b45d2e608a04e6c7132e064a042571a20f371f9f link true /test pull-machine-controller-license-validation
pull-machine-controller-e2e-aws-legacy-userdata b45d2e608a04e6c7132e064a042571a20f371f9f link true /test pull-machine-controller-e2e-aws-legacy-userdata
pull-machine-controller-e2e-azure-custom-image-reference b45d2e608a04e6c7132e064a042571a20f371f9f link true /test pull-machine-controller-e2e-azure-custom-image-reference
pull-machine-controller-e2e-aws-arm b45d2e608a04e6c7132e064a042571a20f371f9f link true /test pull-machine-controller-e2e-aws-arm
pull-machine-controller-e2e-digitalocean b45d2e608a04e6c7132e064a042571a20f371f9f link true /test pull-machine-controller-e2e-digitalocean
pull-machine-controller-e2e-openstack-project-auth b45d2e608a04e6c7132e064a042571a20f371f9f link true /test pull-machine-controller-e2e-openstack-project-auth
pull-machine-controller-e2e-azure b45d2e608a04e6c7132e064a042571a20f371f9f link true /test pull-machine-controller-e2e-azure
pull-machine-controller-e2e-aws b45d2e608a04e6c7132e064a042571a20f371f9f link true /test pull-machine-controller-e2e-aws
pull-machine-controller-e2e-aws-spot-instance b45d2e608a04e6c7132e064a042571a20f371f9f link true /test pull-machine-controller-e2e-aws-spot-instance
pull-machine-controller-e2e-deployment-upgrade b45d2e608a04e6c7132e064a042571a20f371f9f link true /test pull-machine-controller-e2e-deployment-upgrade
pull-machine-controller-e2e-openstack b45d2e608a04e6c7132e064a042571a20f371f9f link true /test pull-machine-controller-e2e-openstack
pull-machine-controller-e2e-aws-ebs-encryption-enabled b45d2e608a04e6c7132e064a042571a20f371f9f link true /test pull-machine-controller-e2e-aws-ebs-encryption-enabled
pull-machine-controller-e2e-hetzner b45d2e608a04e6c7132e064a042571a20f371f9f link true /test pull-machine-controller-e2e-hetzner
pull-machine-controller-e2e-ubuntu-upgrade b45d2e608a04e6c7132e064a042571a20f371f9f link true /test pull-machine-controller-e2e-ubuntu-upgrade
pull-machine-controller-e2e-aws-flatcar-containerd b45d2e608a04e6c7132e064a042571a20f371f9f link true /test pull-machine-controller-e2e-aws-flatcar-containerd

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kubermatic-bot avatar Oct 14 '22 09:10 kubermatic-bot