machine-controller
machine-controller copied to clipboard
kubermatic
Add proxmox cloud provider
What this PR does / why we need it: This is the first part of implementing proxmox as a new cloud provider in KKP.
Reference: https://github.com/kubermatic/kubermatic/issues/9406
Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #1325
Special notes for your reviewer: Proxmox support is experimental and more a tech demo than anything close to being production ready. There are quite a few assumptions made about the Proxmox setup which need to be handled later on with follow-up tasks making things configurable.
TODO:
- [x] Initial Testing
- [x] Create
MachineDeploymentexample yaml - [x] Improved docs
- [x] Add release notes to PR
- [x] Some refactoring/clean-up (deferred to after succesful testing)
- [x] Node selection: Random pick from nodes with sufficient resources
- [x] Cloud-init user-data
Optional Release Note:
Proxmox VE cloud provider support (experimental)
@dermorz please update the what-works section by adding there Proxmox and highlight that it's a technology preview. Could you as well change KubeVirt (experimental) to KubeVirt (Technology Preview)?
Maybe this section needs to be refreshed a little bit to be more readable, but probably not in that PR.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: dermorz
Once this PR has been reviewed and has the lgtm label, please assign moadqassem for approval by writing /assign @moadqassem in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@dermorz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-machine-controller-e2e-azure-custom-image-reference | 74b2b5d25e00fb0e4baf3e95275d03bd3e51ff9f | link | true | /test pull-machine-controller-e2e-azure-custom-image-reference |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@dermorz I forgot about this before, but would it be possible to add a Prow job for e2e testing?
Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close
@kubermatic-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity. Reopen the issue with
/reopen. Mark the issue as fresh with/remove-lifecycle rotten./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.