dashboard
dashboard copied to clipboard
External Cluster(EKS): Support for assume role
What this PR does / why we need it: Support for using assume role for EKS external clusters.
Which issue(s) this PR fixes:
xref https://github.com/kubermatic/kubermatic/issues/11040
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
External clusters on EKS now support assume role.
Documentation:
NONE
Codecov Report
Merging #5199 (73675de) into main (b1f5d0c) will decrease coverage by
0.04%. The diff coverage is24.00%.
@@ Coverage Diff @@
## main #5199 +/- ##
==========================================
- Coverage 48.30% 48.26% -0.05%
==========================================
Files 398 398
Lines 15265 15286 +21
Branches 2721 2724 +3
==========================================
+ Hits 7374 7378 +4
- Misses 7437 7454 +17
Partials 454 454
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/app/core/services/external-cluster.ts | 11.20% <0.00%> (ø) |
|
| ...rnal-cluster-credentials/provider/eks/component.ts | 18.18% <25.00%> (+0.20%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update b1f5d0c...73675de. Read the comment docs.
pre-dashboard-test-unit — Pod got deleted unexpectedly
/retest
/approve Dashboard UI changes look good.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ahmedwaleedmalik, Waseem826
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [Waseem826,ahmedwaleedmalik]
- ~~cmd/kubermatic-api/OWNERS~~ [ahmedwaleedmalik]
- ~~pkg/OWNERS~~ [ahmedwaleedmalik]
- ~~pkg/api/OWNERS~~ [ahmedwaleedmalik]
- ~~pkg/handler/OWNERS~~ [ahmedwaleedmalik]
- ~~pkg/provider/kubernetes/OWNERS~~ [ahmedwaleedmalik]
- ~~src/OWNERS~~ [Waseem826,ahmedwaleedmalik]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
LGTM label has been added.
/retest
LGTM label has been added.
@ahmedwaleedmalik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pre-dashboard-test-e2e-ce | 73675de045ba24f8938c780a2ea298d7eadf59d9 | link | false | /test pre-dashboard-test-e2e-ce |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
LGTM label has been added.