dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

External Cluster(EKS): Support for assume role

Open ahmedwaleedmalik opened this issue 3 years ago • 5 comments

What this PR does / why we need it: Support for using assume role for EKS external clusters.

Which issue(s) this PR fixes:

xref https://github.com/kubermatic/kubermatic/issues/11040

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

External clusters on EKS now support assume role.

Documentation:

NONE

ahmedwaleedmalik avatar Nov 04 '22 07:11 ahmedwaleedmalik

Codecov Report

Merging #5199 (73675de) into main (b1f5d0c) will decrease coverage by 0.04%. The diff coverage is 24.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5199      +/-   ##
==========================================
- Coverage   48.30%   48.26%   -0.05%     
==========================================
  Files         398      398              
  Lines       15265    15286      +21     
  Branches     2721     2724       +3     
==========================================
+ Hits         7374     7378       +4     
- Misses       7437     7454      +17     
  Partials      454      454              
Impacted Files Coverage Δ
src/app/core/services/external-cluster.ts 11.20% <0.00%> (ø)
...rnal-cluster-credentials/provider/eks/component.ts 18.18% <25.00%> (+0.20%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1f5d0c...73675de. Read the comment docs.

codecov[bot] avatar Nov 04 '22 07:11 codecov[bot]

pre-dashboard-test-unit — Pod got deleted unexpectedly 

/retest

ahmedwaleedmalik avatar Nov 04 '22 09:11 ahmedwaleedmalik

/approve Dashboard UI changes look good.

Waseem826 avatar Nov 04 '22 10:11 Waseem826

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubermatic-bot avatar Nov 04 '22 10:11 kubermatic-bot

LGTM label has been added.

Git tree hash: 9b4a70dd40a96cdb97c57aea7e7d6eb098d3d48a

kubermatic-bot avatar Nov 07 '22 11:11 kubermatic-bot

/retest

ahmedwaleedmalik avatar Nov 07 '22 11:11 ahmedwaleedmalik

LGTM label has been added.

Git tree hash: 4f9651375cb301accb8ef241b8eab9fae9ef285d

kubermatic-bot avatar Nov 07 '22 12:11 kubermatic-bot

@ahmedwaleedmalik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-dashboard-test-e2e-ce 73675de045ba24f8938c780a2ea298d7eadf59d9 link false /test pre-dashboard-test-e2e-ce

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kubermatic-bot avatar Nov 07 '22 12:11 kubermatic-bot

LGTM label has been added.

Git tree hash: a3e90466888046bfb6e0d4daa2218877bb8f3af5

kubermatic-bot avatar Nov 07 '22 16:11 kubermatic-bot