dashboard icon indicating copy to clipboard operation
dashboard copied to clipboard

WIP - Update web-terminal Docker image to 0.3

Open xrstf opened this issue 3 years ago • 3 comments

What this PR does / why we need it: https://github.com/kubermatic/kubermatic/pull/11286 built a new image with a more recent kubectl binary on board. This PR makes sure the dashboard is making use of that the image.

What type of PR is this? /kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

xrstf avatar Nov 03 '22 15:11 xrstf

Codecov Report

Merging #5193 (e718ec8) into main (2612fea) will decrease coverage by 0.37%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5193      +/-   ##
==========================================
- Coverage   48.40%   48.03%   -0.38%     
==========================================
  Files         398      398              
  Lines       15227    15789     +562     
  Branches     2709     2914     +205     
==========================================
+ Hits         7371     7584     +213     
- Misses       7407     7715     +308     
- Partials      449      490      +41     
Impacted Files Coverage Δ
src/app/core/services/provider/openstack.ts 40.00% <0.00%> (-10.00%) :arrow_down:
src/app/node-data/dialog/component.ts 21.66% <0.00%> (-6.12%) :arrow_down:
.../app/core/services/node-data/provider/openstack.ts 13.09% <0.00%> (-5.78%) :arrow_down:
src/app/cluster/list/external-cluster/component.ts 52.58% <0.00%> (-2.90%) :arrow_down:
src/app/core/services/external-cluster.ts 8.78% <0.00%> (-2.43%) :arrow_down:
src/app/core/services/wizard/provider/openstack.ts 63.94% <0.00%> (-2.25%) :arrow_down:
...rnal-cluster-credentials/provider/eks/component.ts 17.00% <0.00%> (-0.98%) :arrow_down:
src/app/shared/validators/others.ts 100.00% <0.00%> (ø)
...tails/cluster/machine-deployment-list/component.ts 34.32% <0.00%> (+0.26%) :arrow_up:
src/app/shared/entity/node.ts 19.79% <0.00%> (+1.37%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2612fea...e718ec8. Read the comment docs.

codecov[bot] avatar Nov 03 '22 15:11 codecov[bot]

LGTM label has been added.

Git tree hash: 48ca724f357f20fdd745c4e5de444bf69f5bf01b

kubermatic-bot avatar Nov 08 '22 14:11 kubermatic-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubermatic-bot avatar Nov 08 '22 14:11 kubermatic-bot

/retest

ahmedwaleedmalik avatar Nov 08 '22 15:11 ahmedwaleedmalik