can configure autoscaling options

[furkhat]

What this PR does / why we need it:

It adds autoscaling options in machine deploymens, so users can set min/max replicas

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Partially Fixes https://github.com/kubermatic/kubermatic/issues/6507 Related API changes https://github.com/kubermatic/kubermatic/pull/6596

Special notes for your reviewer: Right now I display autoscaler controls to any cluster. Should we add a condition for displaying them? Like if it certain type of cluster or check if autoscaler is deployed. What approach would you suggest?

Release note:

* Add autoscaler options in machine deployment

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: furkhat To complete the pull request process, please assign lsviben You can assign the PR to them by writing /assign @lsviben in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[kubermatic-bot]

Hi @furkhat. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[maciaszczykm]

/test all

[codecov[bot]]

Codecov Report

Merging #3194 (754b4ea) into master (dfdcc2a) will increase coverage by 1.16%. The diff coverage is n/a.

:exclamation: Current head 754b4ea differs from pull request most recent head c2aa5e0. Consider uploading reports for the commit c2aa5e0 to get more accurate results

@@            Coverage Diff             @@
##           master    #3194      +/-   ##
==========================================
+ Coverage   52.36%   53.53%   +1.16%     
==========================================
  Files         260      254       -6     
  Lines        9291     8980     -311     
  Branches     1178      926     -252     
==========================================
- Hits         4865     4807      -58     
+ Misses       4421     4169     -252     
+ Partials        5        4       -1     

Impacted Files	Coverage Δ
src/app/cluster/services/node.service.ts	48.07% <ø> (ø)
src/app/shared/model/NodeSpecChange.ts	100.00% <ø> (ø)
src/app/core/services/node-data/service.ts	20.00% <0.00%> (-47.17%)	:arrow_down:
...p/cluster/cluster-details/constraints/component.ts	77.52% <0.00%> (-6.23%)	:arrow_down:
src/app/shared/entity/cluster.ts	57.44% <0.00%> (-2.56%)	:arrow_down:
src/app/cluster/cluster-details/component.ts	53.96% <0.00%> (-1.38%)	:arrow_down:
src/app/shared/utils/member-utils/member-utils.ts	85.29% <0.00%> (-1.20%)	:arrow_down:
...p/serviceaccount/token/add/steps/name/component.ts	84.21% <0.00%> (-0.79%)	:arrow_down:
src/app/shared/entity/datacenter.ts	94.73% <0.00%> (-0.51%)	:arrow_down:
src/app/shared/entity/settings.ts	90.24% <0.00%> (-0.46%)	:arrow_down:
... and 267 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dfdcc2a...c2aa5e0. Read the comment docs.

[kubermatic-bot]

@furkhat: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pre-dashboard-build-image	754b4eaf3f48e7bdacc8708692d56d9d8d8a73f2	link	/test pre-dashboard-build-image
pre-dashboard-test-e2e-ce	754b4eaf3f48e7bdacc8708692d56d9d8d8a73f2	link	/test pre-dashboard-test-e2e-ce
pre-dashboard-test-e2e	754b4eaf3f48e7bdacc8708692d56d9d8d8a73f2	link	/test pre-dashboard-test-e2e

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[maciaszczykm]

@furkhat I've added some additional comments. The tests are not passing for some time now. Please take a look on them. In case on any questions ping me here or on Slack.

[furkhat]

@maciaszczykm updated.

This implementation always displays "enable node autoscaling" checkbox even if cluster has no autoscaler deployed. I think we should may it conditional, how would you suggest check that cluster has autoscaler deployed?

[floreks]

@maciaszczykm updated.

This implementation always displays "enable node autoscaling" checkbox even if cluster has no autoscaler deployed. I think we should may it conditional, how would you suggest check that cluster has autoscaler deployed?

@zreigz does API expose any information if the cluster can use autoscaler option?

[ahmedwaleedmalik]

Closing this PR since the API part never made it through and this PR needs heavy refactoring.