pytorch-operator icon indicating copy to clipboard operation
pytorch-operator copied to clipboard

Updated the image name format for the gcr.io.

Open wuchen03 opened this issue 5 years ago • 11 comments

While trying these examples, I found that the format of the image address is not correct, updated them.

wuchen03 avatar Sep 10 '20 06:09 wuchen03

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Sep 10 '20 06:09 google-cla[bot]

Hi @wuchen03. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 10 '20 06:09 k8s-ci-robot

Thanks for your contribution! :tada: :+1:

Please sign Google's CLA, thanks.

gaocegege avatar Sep 10 '20 06:09 gaocegege

@googlebot I signed it!

wuchen03 avatar Sep 10 '20 07:09 wuchen03

Thanks @wuchen03, I think we should wait until we merge https://github.com/kubeflow/pytorch-operator/pull/293 to fix Travis.

andreyvelich avatar Sep 10 '20 20:09 andreyvelich

@wuchen03: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit eaabf13db6cadf2502d62c7ba83844ab7c67a86d link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot avatar Sep 10 '20 21:09 k8s-ci-robot

@wuchen03

Can you rebase the master changes to pass tests? I can approve the change later

Jeffwan avatar Oct 22 '20 17:10 Jeffwan

New changes are detected. LGTM label has been removed.

k8s-ci-robot avatar Oct 27 '20 21:10 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wuchen03 To complete the pull request process, please assign andreyvelich after the PR has been reviewed. You can assign the PR to them by writing /assign @andreyvelich in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 27 '20 21:10 k8s-ci-robot

Coverage Status

Coverage decreased (-0.1%) to 64.11% when pulling 8e9253ce4c9471ed0e7789d2ca58d6a23319090a on wuchen03:master into 92fd22d4117b06dd56a7a76e2005811e1cd55ee6 on kubeflow:master.

coveralls avatar Oct 27 '20 23:10 coveralls

@wuchen03: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit-e2e 8e9253ce4c9471ed0e7789d2ca58d6a23319090a link /test kubeflow-pytorch-operator-presubmit-e2e
kubeflow-pytorch-operator-presubmit 8e9253ce4c9471ed0e7789d2ca58d6a23319090a link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

aws-kf-ci-bot avatar Dec 17 '20 02:12 aws-kf-ci-bot