pytorch-operator icon indicating copy to clipboard operation
pytorch-operator copied to clipboard

Migrate code implementation to kubeflow/common fashion

Open Jeffwan opened this issue 5 years ago • 3 comments

kubeflow/common release a stable version 0.3.1 and we can migrate to use implementation of kubeflow/common.

The change will be similar to change https://github.com/kubeflow/tf-operator/pull/1171.

It would be better to resolve dependencies, upgrade to 0.3.1 for interfaces, and then update implementation.

Hope this can be part of 1.1 release.

Jeffwan avatar Jun 16 '20 23:06 Jeffwan

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.98

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

issue-label-bot[bot] avatar Jun 16 '20 23:06 issue-label-bot[bot]

I am worried if it is little late for the 1.1 release. TF-operator one too has not been tested extensively with common.

johnugeorge avatar Jun 17 '20 03:06 johnugeorge

@johnugeorge Yeah, If we can not catch 1.1 release, I think we can postpone to next release. As TF and Pytorch already graduate to v1, we definitely need more test to avoid regression issues.

Jeffwan avatar Jun 19 '20 19:06 Jeffwan