pytorch-operator
pytorch-operator copied to clipboard
use the priority of kube-batch
I add the priority of kube-batch in pytorch-operator. I changed the code of tf-operator and kubebatch in vender dir,because their code is not latest.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign richardsliu
You can assign the PR to them by writing /assign @richardsliu in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @YesterdayxD. Thanks for your PR.
I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
Coverage remained the same at 85.281% when pulling 6c24d6ea2b40fb543dda96734e470f16c0a11d0d on YesterdayxD:master into 0b237bce03c3268b61f5ba454e7f8d6700b399d1 on kubeflow:master.
@gaocegege Thank you.I will change the code you mentioned
pkg/controller.v1/pytorch/controller.go:1::warning: file is not goimported (goimports)
pkg/controller.v1/pytorch/job.go:1::warning: file is not goimported (goimports)
pkg/controller.v1/pytorch/job.go:221:2:warning: should merge variable declaration with assignment on next line (S1021) (staticcheck)
Thanks
PS, please fix the linting issues.
/ok-to-test
I don't sure that what happen the goimported issue. Is it that golang versions are different? my golang is 1.12.6 Travis CI is go1.10 I don't know how to solve it. can you tell me? @gaocegege Do I need to change my golang version?
@YesterdayxD Then you can address the comments above, I can have a look at the issues.
@gaocegege I fixed the issue about goimports :)
@YesterdayxD: The following tests failed, say /retest to rerun all failed tests:
| Test name | Commit | Details | Rerun command |
|---|---|---|---|
| kubeflow-pytorch-operator-presubmit-e2e | 6c24d6ea2b40fb543dda96734e470f16c0a11d0d | link | /test kubeflow-pytorch-operator-presubmit-e2e |
| kubeflow-pytorch-operator-presubmit | 6c24d6ea2b40fb543dda96734e470f16c0a11d0d | link | /test kubeflow-pytorch-operator-presubmit |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.