pytorch-operator icon indicating copy to clipboard operation
pytorch-operator copied to clipboard

use the priority of kube-batch

Open YesterdayxD opened this issue 6 years ago • 11 comments

I add the priority of kube-batch in pytorch-operator. I changed the code of tf-operator and kubebatch in vender dir,because their code is not latest.

YesterdayxD avatar Aug 19 '19 13:08 YesterdayxD

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign richardsliu You can assign the PR to them by writing /assign @richardsliu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 19 '19 13:08 k8s-ci-robot

Hi @YesterdayxD. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 19 '19 13:08 k8s-ci-robot

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Aug 19 '19 13:08 googlebot

Coverage Status

Coverage remained the same at 85.281% when pulling 6c24d6ea2b40fb543dda96734e470f16c0a11d0d on YesterdayxD:master into 0b237bce03c3268b61f5ba454e7f8d6700b399d1 on kubeflow:master.

coveralls avatar Aug 19 '19 13:08 coveralls

@gaocegege Thank you.I will change the code you mentioned

YesterdayxD avatar Aug 20 '19 02:08 YesterdayxD

pkg/controller.v1/pytorch/controller.go:1::warning: file is not goimported (goimports)

pkg/controller.v1/pytorch/job.go:1::warning: file is not goimported (goimports)

pkg/controller.v1/pytorch/job.go:221:2:warning: should merge variable declaration with assignment on next line (S1021) (staticcheck)

Thanks

PS, please fix the linting issues.

/ok-to-test

gaocegege avatar Aug 20 '19 03:08 gaocegege

I don't sure that what happen the goimported issue. Is it that golang versions are different? my golang is 1.12.6 Travis CI is go1.10 I don't know how to solve it. can you tell me? @gaocegege Do I need to change my golang version?

YesterdayxD avatar Aug 20 '19 06:08 YesterdayxD

@YesterdayxD Then you can address the comments above, I can have a look at the issues.

gaocegege avatar Aug 20 '19 07:08 gaocegege

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Aug 20 '19 08:08 googlebot

@gaocegege I fixed the issue about goimports :)

YesterdayxD avatar Aug 22 '19 02:08 YesterdayxD

@YesterdayxD: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit-e2e 6c24d6ea2b40fb543dda96734e470f16c0a11d0d link /test kubeflow-pytorch-operator-presubmit-e2e
kubeflow-pytorch-operator-presubmit 6c24d6ea2b40fb543dda96734e470f16c0a11d0d link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

aws-kf-ci-bot avatar Dec 17 '20 02:12 aws-kf-ci-bot