pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

feat(sdk): Expose argo retry expression.

Open jmcarp opened this issue 4 years ago • 9 comments

Description of your changes:

Argo retryStrategy includes an expression field. This PR exposes the field in the kfp dsl.

Checklist:

jmcarp avatar Oct 29 '21 02:10 jmcarp

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign chensun after the PR has been reviewed. You can assign the PR to them by writing /assign @chensun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot avatar Oct 29 '21 02:10 google-oss-robot

Hi @jmcarp. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-robot avatar Oct 29 '21 02:10 google-oss-robot

cc @chensun. I haven't found a nice way to work around this, so it would be a helpful addition to the sdk!

jmcarp avatar Nov 05 '21 23:11 jmcarp

/ok-to-test

chensun avatar Nov 11 '21 22:11 chensun

Thanks @chensun! I moved the new argument to the end.

jmcarp avatar Dec 01 '21 04:12 jmcarp

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign chensun after the PR has been reviewed. You can assign the PR to them by writing /assign @chensun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Dec 01 '21 04:12 google-oss-prow[bot]

Ping @chensun. Let me know if this needs more revisions!

jmcarp avatar Dec 12 '21 06:12 jmcarp

@Bobgy would it be possible to include this in the next release?

jmcarp avatar Dec 20 '21 15:12 jmcarp

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 17 '22 05:04 stale[bot]