logging-operator icon indicating copy to clipboard operation
logging-operator copied to clipboard

Make severity configurable in PrometheusRules

Open aditya7302 opened this issue 1 year ago • 2 comments

Fixes #1749

Made changes in pkg/sdk/logging/api/v1beta1/common_types.go to add a severity metrics in the Metrics struct and made changes in fluentbit, fluentd and syslog packages prometheusrules.go and buffervolumeprometheusrules.go .

aditya7302 avatar Jul 05 '24 19:07 aditya7302

Hey @aditya7302,

Thank you for your contribution, currently the CI fails, because the generated CRD files/docs have not been committed. Run the following to fix this:

make check-diff
git add -u
git commit

OverOrion avatar Jul 08 '24 07:07 OverOrion

@aditya7302 can you please take a look at the original issue? Making the severity configurable alone is unfortunately not a good solution, see: https://github.com/kube-logging/logging-operator/issues/1749#issuecomment-2208284749

pepov avatar Jul 08 '24 08:07 pepov

closing in favour of #1790 which is a more flexible solution

pepov avatar Aug 12 '24 08:08 pepov