terraform-hcloud-kube-hetzner
terraform-hcloud-kube-hetzner copied to clipboard
add kubelet configuration
Example:
# https://kubernetes.io/docs/reference/config-api/kubelet-config.v1beta1/
k3s_kubelet_config = <<-EOT
apiVersion: kubelet.config.k8s.io/v1beta1
kind: KubeletConfiguration
imageGCLowThresholdPercent: 40
imageGCHighThresholdPercent: 50
imageMaximumGCAge: 24h
EOT
Thanks @Atrox, that's a better way of configuring it than what we have now with the command line options k3s_server_kubelet_args and k3s_agent_kubelet_args.
Fixed the issues. Thanks for the catch regarding the autoscaler. I don't use those myself so I didn't notice that typo...
@Atrox Again thanks for this. There's one thing though, maybe you are on windows and using a different kind of line ending. Because the diffs change whole blocks and files, it's hard to pin point what actually really changed. Please set your file editor to edit in unix mode, that way I can better review the PR.
@mysticaltech i don't think the issue in that specific block is line endings. I formatted the file, so that all the lines match up with the '='. The same way it currently is, just tried to follow the project style.
Should I remove the formatting?
edit: fwiw, I did the PR on unix
Ah I see @Atrox . In that case, please just run terraform fmt
@mysticaltech fmt doesn't change any file for me. terraform fmt -check successfully exits on my machine.
@mysticaltech did a rebase with master + terraform fmt, alignment with = stays the same.
No worries, thanks for trying, I will test it ASAP and merge!