ktor icon indicating copy to clipboard operation
ktor copied to clipboard

KTOR-1460 Switch to org.w3c.fetch

Open hfhbd opened this issue 4 years ago • 3 comments
trafficstars

2nd PR after KTOR-2230

Subsystem Client, JS

Motivation KTOR-1460

  • browser: Reduce code size by using std lib provided fetch api/classes
  • nodeJS: added minimal defined classes manually

Solution Switch to org.w3c.fetch or use manually defined classes on nodeJS

hfhbd avatar Sep 05 '21 10:09 hfhbd

As you can not test nodeJsProductionRun in unit tests, I used this test project: https://github.com/hfhbd/ktorTestNodeJS with mavenLocal

hfhbd avatar Sep 05 '21 10:09 hfhbd

Hi @hfhbd. JS tests are failing on CI

rsinukov avatar Oct 22 '21 15:10 rsinukov

Could you rebase if if it's actual or should we close?

e5l avatar Jul 08 '22 07:07 e5l

Sorry for the late answer. I rebased it, but removing the classes will break abi.

hfhbd avatar Oct 19 '22 08:10 hfhbd