ktor icon indicating copy to clipboard operation
ktor copied to clipboard

Published 20 hours ago • verified publisher icon ktorio

Improve ktor-client request/response logging

Open dragneelfps opened this issue 5 years ago • 3 comments
trafficstars

Related to https://github.com/ktorio/ktor/issues/1727

dragneelfps avatar Mar 16 '20 15:03 dragneelfps

@dragneelfps The changes seem fine. val logContentType: LogContentType is a nice addition :)

eMZet-zz avatar Mar 17 '20 08:03 eMZet-zz

Just wondering if io.ktor.client.HttpClientConfig 's

/**
* Terminate [HttpClient.responsePipeline] if status code is not success(>=300).
*/
var expectSuccess: Boolean = true

will affect logging error responses if not changed to false.

eMZet-zz avatar Mar 17 '20 08:03 eMZet-zz

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 16 '20 13:05 stale[bot]

Closing this PR as stale

rsinukov avatar Jan 05 '23 18:01 rsinukov