models-web-app icon indicating copy to clipboard operation
models-web-app copied to clipboard

Published 20 hours ago • verified publisher icon kserve

Siyuan upgrade node version in dockerfile

Open tiansiyuan opened this issue 1 year ago • 4 comments

The changed are verified via successful docker build using the new Dockerfile.

tiansiyuan avatar Jun 24 '24 09:06 tiansiyuan

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tiansiyuan Once this PR has been reviewed and has the lgtm label, please assign rimolive for approval by writing /assign @rimolive in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

oss-prow-bot[bot] avatar Jun 24 '24 09:06 oss-prow-bot[bot]

That is even more confusing :-D but at least there is a PR with all fixes.

juliusvonkohout avatar Jun 24 '24 14:06 juliusvonkohout

Can you rebase to master and fix the tests?

juliusvonkohout avatar Jun 26 '24 06:06 juliusvonkohout

@markwinter can you help out here as well?

juliusvonkohout avatar Jun 26 '24 14:06 juliusvonkohout