Hidden columns

[PolGuixe]

trafficstars

Description

Added classes to hide columns:

• col-xs-hidden
• col-sm-hidden
• col-md-hidden
• col-lg-hidden

Check List

instruction : terminal command

• [x] run the build script grunt
• [x] open index.html in a browser & resize to test visual issues

[lgg]

Maybe change classnames to fit bootstrap API?

[PolGuixe]

@lgg good point. Done.

[msiemens]

Any news on this?

[PolGuixe]

@msiemens I think the branch is good to be merged. Although, there are some problems with Travis. @kristoferjoseph according to Travis it is unable to find the config file.

[Falieson]

Citing this PR as the version of flexbox used in my PR https://github.com/roylee0704/react-flexbox-grid/pull/82 to add cols={0} into react-flexbox-grid

[menosprezzi]

Acording to this link https://travis-ci.org/kristoferjoseph/flexboxgrid/pull_requests, seems like the travis build system is not setup well for all this time @kristoferjoseph. Maybe disable the travis build for this tasks is better

[bgarrant]

Has this been merged into latest branch? I really need a few of these visibility classes.

[lgg]

@bgarrant until this PR isn't merged you can use: https://github.com/lgg/flexboxgrid-helpers

[PolGuixe]

@kristoferjoseph what do we need to do to get this approved and merged?

[PolGuixe]

@bgarrant this is the original branch with the hidden classes if you want to use it in the mean time.

[bgarrant]

Thanks PolGuixe and lgg!

[Falieson]

so what needs to be done to get this PR approved?

[b264]

We should all decide on a fork to concentrate on if this can't be merged...

[lgg]

ping @kristoferjoseph

[hassanasad]

I think its a dead project now :( - None of the PR's are getting merged nor are any new commits coming in. Can someone please fork and maintain this project?

[b264]

Do it! and reference this PR so others know about it :sunglasses:

[Falieson]

@PolGuixe could you re-submit the PR to my fork ? https://github.com/Falieson/flexboxgrid

@b264 @hassanasad @lgg @kristoferjoseph I'll step up as maintainer, and @thehappyginger will help me

[PolGuixe]

I'll bé quite busy this week I'll do my best :-).

Pol Guixe

On 1 May 2017, 16:30 +0200, Falieson [email protected], wrote:

@PolGuixe (https://github.com/PolGuixe) could you re-submit the PR to my fork ? https://github.com/Falieson/flexboxgrid

@b264 (https://github.com/b264) @hassanasad (https://github.com/hassanasad) @lgg (https://github.com/lgg) @kristoferjoseph (https://github.com/kristoferjoseph) I'll step up as maintainer, and @thehappyginger (https://github.com/thehappyginger) will help me

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://github.com/kristoferjoseph/flexboxgrid/pull/211#issuecomment-298343271), or mute the thread (https://github.com/notifications/unsubscribe-auth/AGUbsdIEP7UI8lNqrVcRjkfMRqsrfNf1ks5r1eyDgaJpZM4JwmrP).

[Falieson]

@PolGuixe @b264 @hassanasad

I was able to get ahold of @kristoferjoseph and he has said

1. this repo is still being actively maintained
2. all these addon features we want he believes are handled by @lgg 's https://github.com/lgg/flexboxgrid-helpers
3. these features shouldn't be incorporated into flexboxgrid b/c he wants to keep the package size small

Speak up if you have an issue with this resolution, I may rename my fork something like 'flexboxgrid-extended' if there is good reason to have a combined package but I think everyone should just be able to depend on the 2 packages.

[b264]

If https://github.com/kristoferjoseph/flexboxgrid/pull/246 merges, that sounds great

[hassanasad]

@Falieson, @kristoferjoseph seems to have a valid point - However, some of the pull requests (such as XL breakpoint support and few helpers such as this) might not add that much weight to the package and they are kinda like becoming a standard requirement for a grid system.

To be honest, in my personal opinion - when the css grid layout rolls out in main stream browsers some of the code from these packages can be cleared out to bring it back to a very small sized package.

[Falieson]

@hassanasad I agree that I expect some features to be apart of the standard offering, but that's because my first grid was http://materializecss.com/grid.html

[b264]

Without at a minimum https://github.com/kristoferjoseph/flexboxgrid/pull/246 merging, it does not appear this repo is maintained.

[cyberhck]

Why is this PR not merged? isn't this supposed to be a standard feature? Is this going to get merged or not? If it's not gonna get merged, simply closing the PR would be better, if it's gonna get merged, some activity would have been nice.

[lgg]

@cyberhck check @kristoferjoseph answer here: https://github.com/kristoferjoseph/flexboxgrid/pull/211#issuecomment-298641394

[b264]

@lgg TL;DR: This repo is unmaintained and abandoned

[cyberhck]

@b264 you seem to be very correct :)

[lgg]

@cyberhck @b264 no, you are wrong. This repo is maintained, but @kristoferjoseph don't want to add current feature to code.

[cyberhck]

@lgg , I was looking for react-flexbox-grid, because of not adding basic feature to this repo, I've to find a entirely new grid library written for react, has visibility classes AND has at least typescript definition.

[b264]

@lgg Here is part of the !TL;DR version: It's not maintained if a simple documentation clarification https://github.com/kristoferjoseph/flexboxgrid/pull/246 can't be merged. There are no reasons to not merge or at least review helpful documentation which has been submitted as a pull request, aside from the repo not being maintained. It really is that simple. Do we want to keep going? Clearly, you have a goal in helping @kristoferjoseph making it look like this is maintained but alas it is not. Why do you fool yourself? Everything here is write-only. https://github.com/kristoferjoseph/flexboxgrid/issues/248 @cyberhck If @kristoferjoseph really feels how he wrote he does, then he, at a minimum, could update documentation, or allow others to update it, indicating that the source code won't ever be changed. But, he doesn't even do that. He does nothing. If you feel that "unmaintained" has some other definition that everyone else here is unaware of, please do clarify exactly what it means. Because my new definition of "unmaintained" is "like kristoferjoseph/flexboxgrid"

TL;DR: This repository is a poster child for a repo being unmaintained.