wanderlust
wanderlust copied to clipboard
Refactoring backend using typescript
Please add description, though the title explains the issue :)
I would like to implement a SOA using OOPs in TypeScript where the architecture will be like as follows:
Sure, but presently we already have decent folder architecture which has good seperation of concerns as below
How does project benefit by using the above SOA architecture, because we are not having multiple services even in the near future, so I feel clean architecture would be a perfect fit here in terms of architecture than SOA.
For now may be we can refactor the backend to use ts instead of js and leave the architecture for now as suggested in the title of the issue
Is anyone doing this? If not could you please assign this to me
Hey @krishnaacharyaa I can take this and migrate backend in one go to typescript and later on gradually as people get comfortable they can start writing types for respective code.
A single pr to introduce typescript using ts-migrate something.
@shmbajaj yeah sure. We'll do this, I am working on integration tests for backend, as soon as that is merged, lets do this
I see the backend is yet to be converted into typescript. if no one's currently assigned then maybe I can take up the job.
Please tell the approach and ETA @ppriyankuu
I can migrate the files to typescript with minimal types, and later as time goes eventually others can start writing their detailed extensive types.
It'll take a day. At max.
Sure please go ahead kindly follow PR guidelines
Sure!!
@krishnaacharyaa Can you assign me this issue so i can try to make conversions and please give it a gssoc'24 tag and the level tag
@vamsidhar-914 would you like to take this?
Yeahh sure...I'll be on itt @krishnaacharyaa
hi @krishnaacharyaa
update: almost migrated all JS files to TS with all the types included , didnt touched tests as i didnt work on tests before, it might take some time to do,might use some help on the tests
Sure @vamsidhar-914, waiting for the PR
@krishnaacharyaa opened
@shivansh84ya can you take this up?
You have to follow https://github.com/krishnaacharyaa/wanderlust/pull/408 and #156 you would have to see and then cover the review comments that's it @shivansh84ya let me know if this interests you
@shivansh84ya acknowledgement please. If you are not interested someone else will pick this up
Hi @krishnaacharyaa,
I am ready to Refactoring backend using typescript. Could you please provide more details about this issue and any specific guidelines I should follow?
Thank you!
You have to follow #408 and #156 you would have to see and then cover the review comments that's it @shivansh84ya let me know if this interests you
@shivansh84ya . Best practices of nodejs ts And our normal contributing guidelines, nothing else apart from that ....!
Hey @shivansh84ya 🎉! Thanks for jumping on this issue. Before you dive in, please check out our contributing guidelines to ensure we're all on the same page. Happy coding! 🚀