wanderlust icon indicating copy to clipboard operation
wanderlust copied to clipboard

Refactoring backend using typescript

Open darshaandaghicha opened this issue 2 years ago • 24 comments
trafficstars

darshaandaghicha avatar Oct 28 '23 18:10 darshaandaghicha

Please add description, though the title explains the issue :)

krishnaacharyaa avatar Oct 29 '23 03:10 krishnaacharyaa

I would like to implement a SOA using OOPs in TypeScript where the architecture will be like as follows: image

darshaandaghicha avatar Oct 29 '23 04:10 darshaandaghicha

Sure, but presently we already have decent folder architecture which has good seperation of concerns as below image

How does project benefit by using the above SOA architecture, because we are not having multiple services even in the near future, so I feel clean architecture would be a perfect fit here in terms of architecture than SOA.

krishnaacharyaa avatar Oct 29 '23 06:10 krishnaacharyaa

For now may be we can refactor the backend to use ts instead of js and leave the architecture for now as suggested in the title of the issue

krishnaacharyaa avatar Oct 29 '23 06:10 krishnaacharyaa

Is anyone doing this? If not could you please assign this to me

MunavvarSinan avatar Dec 03 '23 09:12 MunavvarSinan

Hey @krishnaacharyaa I can take this and migrate backend in one go to typescript and later on gradually as people get comfortable they can start writing types for respective code.

A single pr to introduce typescript using ts-migrate something.

bajajcodes avatar Dec 17 '23 12:12 bajajcodes

@shmbajaj yeah sure. We'll do this, I am working on integration tests for backend, as soon as that is merged, lets do this

krishnaacharyaa avatar Dec 18 '23 12:12 krishnaacharyaa

I see the backend is yet to be converted into typescript. if no one's currently assigned then maybe I can take up the job.

ppriyankuu avatar Apr 18 '24 04:04 ppriyankuu

Please tell the approach and ETA @ppriyankuu

krishnaacharyaa avatar Apr 18 '24 04:04 krishnaacharyaa

I can migrate the files to typescript with minimal types, and later as time goes eventually others can start writing their detailed extensive types.

It'll take a day. At max.

ppriyankuu avatar Apr 18 '24 10:04 ppriyankuu

Sure please go ahead kindly follow PR guidelines

krishnaacharyaa avatar Apr 18 '24 10:04 krishnaacharyaa

Sure!!

ppriyankuu avatar Apr 18 '24 10:04 ppriyankuu

@krishnaacharyaa Can you assign me this issue so i can try to make conversions and please give it a gssoc'24 tag and the level tag

amit429 avatar May 14 '24 18:05 amit429

@vamsidhar-914 would you like to take this?

krishnaacharyaa avatar Jun 07 '24 09:06 krishnaacharyaa

Yeahh sure...I'll be on itt @krishnaacharyaa

vamsidhar-914 avatar Jun 07 '24 12:06 vamsidhar-914

hi @krishnaacharyaa

update: almost migrated all JS files to TS with all the types included , didnt touched tests as i didnt work on tests before, it might take some time to do,might use some help on the tests

vamsidhar-914 avatar Jun 07 '24 17:06 vamsidhar-914

Sure @vamsidhar-914, waiting for the PR

krishnaacharyaa avatar Jun 07 '24 19:06 krishnaacharyaa

@krishnaacharyaa opened

vamsidhar-914 avatar Jun 07 '24 19:06 vamsidhar-914

@shivansh84ya can you take this up?

krishnaacharyaa avatar Jul 03 '24 10:07 krishnaacharyaa

You have to follow https://github.com/krishnaacharyaa/wanderlust/pull/408 and #156 you would have to see and then cover the review comments that's it @shivansh84ya let me know if this interests you

krishnaacharyaa avatar Jul 03 '24 10:07 krishnaacharyaa

@shivansh84ya acknowledgement please. If you are not interested someone else will pick this up

krishnaacharyaa avatar Jul 05 '24 14:07 krishnaacharyaa

Hi @krishnaacharyaa,

I am ready to Refactoring backend using typescript. Could you please provide more details about this issue and any specific guidelines I should follow?

Thank you!

shivansh84ya avatar Jul 10 '24 07:07 shivansh84ya

You have to follow #408 and #156 you would have to see and then cover the review comments that's it @shivansh84ya let me know if this interests you

@shivansh84ya . Best practices of nodejs ts And our normal contributing guidelines, nothing else apart from that ....!

krishnaacharyaa avatar Jul 10 '24 07:07 krishnaacharyaa

Hey @shivansh84ya 🎉! Thanks for jumping on this issue. Before you dive in, please check out our contributing guidelines to ensure we're all on the same page. Happy coding! 🚀

github-actions[bot] avatar Jul 10 '24 07:07 github-actions[bot]