Krishan Patel

Results 8 comments of Krishan Patel

> Overall looks great, let's get this to green CI (formatting check might be borked on our side, will fix on Tuesday, but version change will be required) and then...

@natikgadzhi i would love another review if you have a minute? i had to rebase everything because of the big format change PR that went in.

@marcosmarxm thanks for the comments. i think I've addressed them all now, apologies if i've left something out pls do let me know

> @krishan711 let's figure out what to do with the composite PK in the stream. This is the biggest problem, once you figure it out, we're happy to merge. @natikgadzhi...

> Re-running CI, we've fixed formatting on master. Let's see how that performs. Left a nit on how you set primary key, but otherwise seems okay. > > Setting to...

@ckifer sorry for lame question - I'm testing with the alpha (`alpha8`) (so far great, love the outerRadius function on PieChart) but I can't figure out how to get the...

Thanks for the help, in case someone comes along later this helped me on chrome: `svg:focus, g:focus, path:focus {outline: none}`